Repository navigation
fix: Do not simply use bearer token from cookie for auth - #326
Merged
Merged
Conversation
This approach is/may be vulnerable to a CSRF attack. More care/research is needed before taking this approach. For now, it's safer to simply use the authorization header.
Merged
spencewenski
added a commit
that referenced
this pull request
Aug 12, 2024
## 🤖 New release * `roadster`: 0.5.18 -> 0.5.19 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.5.19](roadster-v0.5.18...roadster-v0.5.19) - 2024-08-12 ### Added - Redact bearer tokens in insta snapshots ([#325](#325)) ### Fixed - Do not simply use bearer token from cookie for auth ([#326](#326)) - Set default value for Jwt cookie name ([#324](#324)) - Derive `Clone` in JWT claim types ([#323](#323)) - Use `leptos_routes` in leptos example instead of `leptos_routes_with_context` ([#322](#322)) ### Other - *(deps)* Bump EmbarkStudios/cargo-deny-action from 1 to 2 ([#319](#319)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach is/may be vulnerable to a CSRF attack. More care/research is needed before taking this approach. For now, it's safer to simply use the authorization header.