Skip to content

feat: Add support to config for email via SMTP (email-smtp feature) - #388

Merged
spencewenski merged 1 commit into
mainfrom
gh-2-email
Oct 7, 2024
Merged

spencewenski merged 1 commit into
mainfrom
gh-2-email

Conversation

@spencewenski

Copy link
Copy Markdown
Member

Also:

  • Move contents of module app_config to parent config module
  • Update feature_powerset feature groups
  • Add lettre dependency for email/smtp support
  • Add cargo-insta to just init command

@spencewenski spencewenski mentioned this pull request Oct 7, 2024
@spencewenski
spencewenski force-pushed the gh-2-email branch 2 times, most recently from 5a91fbf to 16d7113 Compare October 7, 2024 06:50
Also:

- Move contents of module `app_config` to parent `config` module
- Update `feature_powerset` feature groups
- Add `lettre` dependency for email/smtp support
- Add `cargo-insta` to `just init` command
- Add `--no-fail-fast` to `just test` sub-commands and `pre-push` hook
@codecov

codecov Bot commented Oct 7, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 29.32331% with 94 lines in your changes missing coverage. Please review.

Project coverage is 43.02%. Comparing base (eda5eb8) to head (eb65f80).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/config/mod.rs 28.69% 82 Missing ⚠️
src/config/email/smtp.rs 29.41% 12 Missing ⚠️
Files with missing lines Coverage Δ
src/api/http/docs.rs 65.34% <ø> (ø)
src/api/http/health.rs 23.91% <ø> (ø)
src/api/http/ping.rs 40.00% <ø> (ø)
src/app/context.rs 22.38% <ø> (ø)
src/app/mod.rs 0.00% <ø> (ø)
src/app/roadster_app.rs 0.00% <ø> (ø)
src/config/database/mod.rs 89.65% <ø> (ø)
src/config/email/mod.rs 100.00% <100.00%> (ø)
src/config/environment.rs 8.33% <ø> (ø)
src/config/health_check/mod.rs 100.00% <ø> (ø)
... and 27 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda5eb8...eb65f80. Read the comment docs.

@spencewenski
spencewenski merged commit b7eeac3 into main Oct 7, 2024
@spencewenski
spencewenski deleted the gh-2-email branch October 7, 2024 07:06
This was referenced Oct 7, 2024
spencewenski added a commit that referenced this pull request Oct 9, 2024
## 🤖 New release
* `roadster`: 0.6.4 -> 0.6.5 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.6.5](roadster-v0.6.4...roadster-v0.6.5)
- 2024-10-09

### Added

- Add `SmtpHealthCheck`
([#396](#396))
- Allow specifying the smtp port via config
([#395](#395))
- Add smtp client to `AppContext`
([#391](#391))
- Add support to config for email via SMTP (`email-smtp` feature)
([#388](#388))

### Fixed

- Fix config value used for timeout of health check in api and cli
([#397](#397))

### Other

- Add example of sending email using lettre smtp client
([#394](#394))
- Add doc comment explaining how NormalizePathLayer works
([#393](#393))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant