feat: Allow specifying the smtp port via config#395
Merged
Conversation
Also, update READMEs to add instructions for how to start a local smtp server for dev/testing. Also, don't run pre-push checks against entire workspace, just roadster
Open
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Merged
spencewenski
added a commit
that referenced
this pull request
Oct 9, 2024
## 🤖 New release * `roadster`: 0.6.4 -> 0.6.5 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.6.5](roadster-v0.6.4...roadster-v0.6.5) - 2024-10-09 ### Added - Add `SmtpHealthCheck` ([#396](#396)) - Allow specifying the smtp port via config ([#395](#395)) - Add smtp client to `AppContext` ([#391](#391)) - Add support to config for email via SMTP (`email-smtp` feature) ([#388](#388)) ### Fixed - Fix config value used for timeout of health check in api and cli ([#397](#397)) ### Other - Add example of sending email using lettre smtp client ([#394](#394)) - Add doc comment explaining how NormalizePathLayer works ([#393](#393)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, update READMEs to add instructions for how to start a local smtp server for dev/testing.
Also, don't run pre-push checks against entire workspace, just roadster