feat: Allow configuring which req/res body content types to log#407
Merged
Conversation
Some req/res body content types are more useful to log than others. For example, it's not generally helpful to log `image/x-icon` or `text/javascript`. However, it can still be very useful for debugging to log things like `application/json` or `application/x-www-form-urlencoded`. Allow configuring which content types to allow to be logged. By default, all content types are allowed. Currently, only exact matches of content types are supported, so using `text/*` will not match `text/plain`, for example.
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Merged
spencewenski
pushed a commit
that referenced
this pull request
Oct 11, 2024
## 🤖 New release * `roadster`: 0.6.7 -> 0.6.8 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.6.8](roadster-v0.6.7...roadster-v0.6.8) - 2024-10-11 ### Added - Allow configuring which req/res body content types to log ([#407](#407)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some req/res body content types are more useful to log than others. For example, it's not generally helpful to log
image/x-iconortext/javascript. However, it can still be very useful for debugging to log things likeapplication/jsonorapplication/x-www-form-urlencoded.Allow configuring which content types to allow to be logged. By default, all content types are allowed. Currently, only exact matches of content types are supported, so using
text/*will not matchtext/plain, for example.Closes #390