feat: Add AnyMiddleware to minimize boilerplate for Axum middleware - #472
Merged
Conversation
If a consumer wants to use a middleware that's not already supported by Roadster, they need to implement the `Middleware` trait, which is extra boilerplate that could be annoying. Add `AnyMiddleware` struct that implements the `Middleware` trait, so consumers just need to provide the name of the middleware and the logic to build/configure it. Closes #470
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Merged
spencewenski
added a commit
that referenced
this pull request
Oct 21, 2024
## 🤖 New release * `roadster`: 0.6.13 -> 0.6.14 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.6.14](roadster-v0.6.13...roadster-v0.6.14) - 2024-10-21 ### Added - Add `AnyMiddleware` to minimize boilerplate for Axum middleware ([#472](#472)) ### Other - A couple minor fixes for the loco comparison ([#471](#471)) - Update book favicon color ([#469](#469)) - Update Roadster features index.md ([#467](#467)) - Update links in getting started index ([#466](#466)) - Add leptos-0.7 example ([#465](#465)) - Update doc test log group name in feature powerset workflow ([#464](#464)) - Add links to relevant docs.rs links in book chapters ([#463](#463)) - Add Leptos comparison ([#462](#462)) - Add utility to generate the feature "powerset" list ([#454](#454)) - Update openapi features in loco comparison ([#452](#452)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a consumer wants to use a middleware that's not already supported by Roadster, they need to implement the
Middlewaretrait, which is extra boilerplate that could be annoying.Add
AnyMiddlewarestruct that implements theMiddlewaretrait, so consumers just need to provide the name of the middleware and the logic to build/configure it.Also fixes issue of incorrect feature name used in cfg_if block to enable yaml config files.
Closes #470