feat: Set HTTP request span name as {method} {route} - #748
Merged
Conversation
The OTEL semantic conventions specify that an HTTP request span should
be named `{method} {target}` if the method and target (route) if that
information is available. The `tracing-opentelemtry` crate allows
setting a dynamic span name using the `otel.name` field, which allows us
to use the method/route in the span name.
This PR also sets the http span kind as `SERVER`
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Merged
spencewenski
added a commit
that referenced
this pull request
Apr 29, 2025
## 🤖 New release * `roadster`: 0.7.3 -> 0.7.4 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.7.4](roadster-v0.7.3...roadster-v0.7.4) - 2025-04-29 ### Added - Set HTTP request span name as `{method} {route}` ([#748](#748)) ### Other - Update README.md ([#743](#743)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OTEL semantic conventions specify that an HTTP request span should be named
{method} {target}if the method and target (route) are available. Thetracing-opentelemtrycrate allows setting a dynamic span name using theotel.namefield, which allows us to use the method/route in the span name.This PR also sets the http span kind as
SERVER