chore!: Migrate from typed-builder to bon - #831
Merged
Merged
Conversation
The resulting APIs are mostly compatible. However, optional setters were renamed from `*_opt` to `maybe_*`.
Closed
spencewenski
pushed a commit
that referenced
this pull request
Jul 13, 2025
## 🤖 New release * `roadster`: 0.8.0-alpha.1 -> 0.8.0-alpha.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.8.0-alpha.2](roadster-v0.8.0-alpha.1...roadster-v0.8.0-alpha.2) - 2025-07-13 ### Other - [**breaking**] Migrate from `typed-builder` to `bon` ([#831](#831)) - [**breaking**] Add `skip_serializing_none` to serialized structs ([#830](#830)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Veetaha
reviewed
Jul 13, 2025
| pub status: Status, | ||
| /// Total latency of checking the health of the resource in milliseconds. | ||
| #[builder(setter(transform = |duration: std::time::Duration| duration.as_millis()))] | ||
| #[builder(setters(vis = "", name = latency_internal))] |
There was a problem hiding this comment.
Hi, this could be expressed via a one-liner #[builder(with)]. Pointing this out in case if you missed
Suggested change
| #[builder(setters(vis = "", name = latency_internal))] | |
| #[builder(with = |duration: std::time::Duration| duration.as_millis())] |
Member
Author
There was a problem hiding this comment.
Ah, cool, thanks @Veetaha. I'm pretty new to bon, so I didn't know about this. I'll check it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resulting APIs are mostly compatible. However, optional setters were renamed from
*_opttomaybe_*.