chore: Use #[builder(with)] for custom builder setters - #836
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
spencewenski
pushed a commit
that referenced
this pull request
Jul 14, 2025
## 🤖 New release
* `roadster`: 0.8.0-alpha.2 -> 0.8.0-alpha.3 (⚠ API breaking changes)
### ⚠ `roadster` breaking changes
```text
--- failure trait_method_requires_different_generic_type_params: trait method now requires a different number of generic type parameters ---
Description:
A trait method now requires a different number of generic type parameters than it used to. Calls or implementations of this trait method using the previous number of generic types will be broken.
ref: https://doc.rust-lang.org/reference/items/generics.html
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/trait_method_requires_different_generic_type_params.ron
Failed in:
Worker::enqueue_delayed (0 -> 1 generic types) in /tmp/.tmpuikZ3n/roadster/src/worker/mod.rs:88
Worker::enqueue_batch (0 -> 1 generic types) in /tmp/.tmpuikZ3n/roadster/src/worker/mod.rs:102
Worker::enqueue_batch_delayed (0 -> 1 generic types) in /tmp/.tmpuikZ3n/roadster/src/worker/mod.rs:115
```
<details><summary><i><b>Changelog</b></i></summary><p>
<blockquote>
##
[0.8.0-alpha.3](roadster-v0.8.0-alpha.2...roadster-v0.8.0-alpha.3)
- 2025-07-14
### Fixed
- Allow enqueue_delayed and enqueue_batch* to take owned or ref
([#834](#834))
### Other
- Use `#[builder(with)]` for custom builder setters
([#836](#836))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #835