Skip to content

feat: Add meaningful prefix to some generic trace event labels - #861

Merged
spencewenski merged 1 commit into
mainfrom
namespaced-trace-attributes
Jul 19, 2025
Merged

feat: Add meaningful prefix to some generic trace event labels#861
spencewenski merged 1 commit into
mainfrom
namespaced-trace-attributes

Conversation

@spencewenski

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jul 19, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 35.06494% with 50 lines in your changes missing coverage. Please review.

Project coverage is 48.10%. Comparing base (d9e32f5) to head (180b70a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/app/run.rs 0.00% 12 Missing ⚠️
src/worker/backend/pg/enqueue.rs 31.25% 11 Missing ⚠️
src/worker/backend/pg/processor/mod.rs 0.00% 7 Missing ⚠️
src/config/tracing/mod.rs 50.00% 5 Missing ⚠️
src/worker/backend/sidekiq/processor/builder.rs 0.00% 3 Missing ⚠️
src/lifecycle/registry.rs 0.00% 2 Missing ⚠️
src/worker/backend/sidekiq/enqueue.rs 0.00% 2 Missing ⚠️
src/worker/enqueue.rs 0.00% 2 Missing ⚠️
src/worker/mod.rs 0.00% 2 Missing ⚠️
src/db/migration/diesel/mod.rs 0.00% 1 Missing ⚠️
... and 3 more
Files with missing lines Coverage Ξ”
src/api/core/health.rs 24.07% <100.00%> (ΓΈ)
src/app/context/extension.rs 100.00% <100.00%> (ΓΈ)
src/health/check/registry.rs 96.55% <100.00%> (ΓΈ)
src/service/http/builder.rs 84.39% <100.00%> (ΓΈ)
src/service/registry.rs 100.00% <100.00%> (ΓΈ)
src/db/migration/diesel/mod.rs 0.00% <0.00%> (ΓΈ)
src/service/http/middleware/tracing/mod.rs 45.23% <0.00%> (ΓΈ)
src/service/runner.rs 0.00% <0.00%> (ΓΈ)
src/worker/backend/pg/processor/builder.rs 70.09% <66.66%> (ΓΈ)
src/lifecycle/registry.rs 18.18% <0.00%> (ΓΈ)
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update d9e32f5...180b70a. Read the comment docs.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencewenski
spencewenski merged commit b6de753 into main Jul 19, 2025
29 of 30 checks passed
@spencewenski
spencewenski deleted the namespaced-trace-attributes branch July 19, 2025 18:13
spencewenski pushed a commit that referenced this pull request Jul 19, 2025
## πŸ€– New release

* `roadster`: 0.8.0-rc.1 -> 0.8.0-rc.2 (βœ“ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.8.0-rc.2](roadster-v0.8.0-rc.1...roadster-v0.8.0-rc.2)
- 2025-07-19

### Added

- [**breaking**] Add `id` field to internal `Job` struct
([#862](#862))
- Add meaningful prefix to some generic trace event labels
([#861](#861))

### Other

- Disable auto release PRs for now
([#860](#860))
- Disable workflows on v0.8 branch
([#859](#859))
- Remove previous results from worker m3 benchmarks
([#858](#858))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
spencewenski added a commit that referenced this pull request Jul 25, 2025
## πŸ€– New release

* `roadster`: 0.8.0-rc.4 -> 0.8.0 (βœ“ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.8.0](roadster-v0.7.4...roadster-v0.8.0)
- 2025-07-25

The main feature added in v0.8.0 compared to v0.7* is support for using
Postgres as the backing store for async queues in addition to
Redis/Sidekiq. Adding this feature required making breaking changes to
our Sidekiq support in order to align both solutions to use the same
`Worker` trait. Some config structs were refactored as well,
particularly ones related to the DB and workers. See the release notes
for [0.8.0-alpha.1](#80-alpha1---2025-07-13) for more details. See also
the [background jobs
chapter](https://roadster.dev/features/services/background-jobs/index.html)
of the book for details on the new background job support.

In addition, v0.8.0 release contains a few smaller features and breaking
changes. A full list can be found in the changelog for the pre-release
versions, but a summary is included below.

### Added

- [**breaking**] Remove `sidekiq` and `sea-orm` from default features
([#872](#872))
- Add meaningful prefix to some generic trace event labels
([#861](#861))
- Improve Worker::handle trace span name
([#850](#850))
- Allow configuring sqlx statement logging
([#838](#838))

</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant