chore!: Remove sidekiq and sea-orm from default features#872
Merged
Conversation
Updates the `default` feature to remove sea-orm. Roadster no longer suggests a particular DB solution as the default. Instead, consumers should enable the `db-sea-orm` or `db-diesel-*` feature depending on the preferred solution. Also updates the `default-common` feature to remove the sidekiq feature. Roadster no longer suggests a particular worker backend solution as the default. Instead, consumers should enable the `worker-sidekiq` or `worker-pg` feature depending on the preferred solution. This PR also removes the `default-diesel` feature.
Codecov ReportAttention: Patch coverage is
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
spencewenski
pushed a commit
that referenced
this pull request
Jul 24, 2025
## 🤖 New release
* `roadster`: 0.8.0-rc.3 -> 0.8.0-rc.4 (⚠ API breaking changes)
### ⚠ `roadster` breaking changes
```text
--- failure feature_missing: package feature removed or renamed ---
Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/feature_missing.ron
Failed in:
feature default-common in the package's Cargo.toml
feature default-diesel in the package's Cargo.toml
--- failure feature_not_enabled_by_default: package feature is not enabled by default ---
Description:
A feature is no longer enabled by default for this package. This will break downstream crates which rely on the package's default features and require the functionality of this feature.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove-another
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/feature_not_enabled_by_default.ron
Failed in:
feature db-sea-orm in the package's Cargo.toml
feature db-sql in the package's Cargo.toml
feature worker-sidekiq in the package's Cargo.toml
feature worker in the package's Cargo.toml
--- failure module_missing: pub module removed or renamed ---
Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/module_missing.ron
Failed in:
mod roadster::health::check::sidekiq_fetch, previously in file /tmp/.tmpano8uO/roadster/src/health/check/sidekiq_fetch.rs:1
mod roadster::health::check::sidekiq_enqueue, previously in file /tmp/.tmpano8uO/roadster/src/health/check/sidekiq_enqueue.rs:1
--- failure struct_missing: pub struct removed or renamed ---
Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/struct_missing.ron
Failed in:
struct roadster::health::check::sidekiq_fetch::SidekiqFetchHealthCheck, previously in file /tmp/.tmpano8uO/roadster/src/health/check/sidekiq_fetch.rs:8
struct roadster::health::check::sidekiq_enqueue::SidekiqEnqueueHealthCheck, previously in file /tmp/.tmpano8uO/roadster/src/health/check/sidekiq_enqueue.rs:8
--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---
Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/struct_pub_field_missing.ron
Failed in:
field sidekiq of struct HealthCheck, previously in file /tmp/.tmpano8uO/roadster/src/config/health/check/mod.rs:33
```
<details><summary><i><b>Changelog</b></i></summary><p>
<blockquote>
##
[0.8.0-rc.4](roadster-v0.8.0-rc.3...roadster-v0.8.0-rc.4)
- 2025-07-24
### Added
- [**breaking**] Add health check for Postgres-backed worker
([#873](#873))
### Fixed
- *(docs)* Fix typo in config chapter
([#871](#871))
- *(docs)* Fix typos in book
([#870](#870))
### Other
- [**breaking**] Remove sidekiq and sea-orm from default features
([#872](#872))
- `derive_more` to impl Display and Deref/DerefMut for some types
([#867](#867))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
spencewenski
added a commit
that referenced
this pull request
Jul 25, 2025
## 🤖 New release * `roadster`: 0.8.0-rc.4 -> 0.8.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.8.0](roadster-v0.7.4...roadster-v0.8.0) - 2025-07-25 The main feature added in v0.8.0 compared to v0.7* is support for using Postgres as the backing store for async queues in addition to Redis/Sidekiq. Adding this feature required making breaking changes to our Sidekiq support in order to align both solutions to use the same `Worker` trait. Some config structs were refactored as well, particularly ones related to the DB and workers. See the release notes for [0.8.0-alpha.1](#80-alpha1---2025-07-13) for more details. See also the [background jobs chapter](https://roadster.dev/features/services/background-jobs/index.html) of the book for details on the new background job support. In addition, v0.8.0 release contains a few smaller features and breaking changes. A full list can be found in the changelog for the pre-release versions, but a summary is included below. ### Added - [**breaking**] Remove `sidekiq` and `sea-orm` from default features ([#872](#872)) - Add meaningful prefix to some generic trace event labels ([#861](#861)) - Improve Worker::handle trace span name ([#850](#850)) - Allow configuring sqlx statement logging ([#838](#838)) </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Spencer Ferris <3319370+spencewenski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
defaultfeature to remove sea-orm. Roadster no longer suggests a particular DB solution as the default. Instead, consumers should enable thedb-sea-ormordb-diesel-*feature depending on the preferred solution.Also updates the
default-commonfeature to remove the sidekiq feature. Roadster no longer suggests a particular worker backend solution as the default. Instead, consumers should enable theworker-sidekiqorworker-pgfeature depending on the preferred solution.This PR also removes the
default-dieselfeature.