Skip to content

use recommended omit rather than only on npm install#33

Merged
robb-j merged 2 commits intorobb-j:mainfrom
patrickfatrick:fix-npm-install
Apr 7, 2023
Merged

use recommended omit rather than only on npm install#33
robb-j merged 2 commits intorobb-j:mainfrom
patrickfatrick:fix-npm-install

Conversation

@patrickfatrick
Copy link
Contributor

@patrickfatrick patrickfatrick commented Feb 24, 2023

This extension displays the below NPM warning, which makes it seem like something went wrong upon instantiating.

ERROR(npm install): npm WARN config only Use `--omit=dev` to omit dev dependencies from the install.

Although --only is still supported it's been deprecated and is no longer documented as of v7. This PR simply changes it to the now-recommended --omit flag.

@robb-j
Copy link
Owner

robb-j commented Feb 27, 2023

Hey, thanks for your PR, it makes sense and is well motivated! I can't fully review it right now but can hopefully get to it soon.

@robb-j
Copy link
Owner

robb-j commented Apr 7, 2023

Thanks for the PR, it all looks good!

@robb-j robb-j merged commit dc22f9b into robb-j:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants