DDLog compile errors in command-line tool targets

[snej]

Added GCDAsyncSocket to a brand new command-line-tool project in Xcode 6.3 and got compile errors in DDLog.m — it's referencing AppKit symbols NSApp and NSApplication but doesn't #import AppKit headers; apparently it assumes the target prefix header will have imported these already.

At a higher level, this code is assuming that any non-iOS target will be linked against AppKit, which isn't true for many non-GUI programs. (And such programs shouldn't be linked with AppKit if it's not necessary, because that ends up creating WindowServer connections that increase startup time and memory usage.)

/Couchbase/BLIPSync/vendor/WebSockets-Cocoa/vendor/CocoaAsyncSocket/Vendor/CocoaLumberjack/DDLog.m:158:13: error: use of undeclared identifier 'NSApp'
        if (NSApp)
            ^
/Couchbase/BLIPSync/vendor/WebSockets-Cocoa/vendor/CocoaAsyncSocket/Vendor/CocoaLumberjack/DDLog.m:911:19: error: use of undeclared identifier 'NSApplication'; did you mean 'cApplication'?
                [[NSApplication sharedApplication] respondsToSelector:@selector(occlusionState)] // OS X 10.9+
                  ^~~~~~~~~~~~~
                  cApplication
...

[snej]

Looks like this has been fixed for a while in the CocoaLumberjack repo — the offending code is now conditionalized with #ifdef NSAppKitVersionNumber10_0. Could you please update the copy included in CocoaAsyncSocket?

[github-actions]

This issue has been marked as stale, it will be closed automatically if there is no further activity.