Navigation Menu

Skip to content

Commit

Permalink
Formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
ObjColumnist committed Nov 13, 2013
1 parent e165673 commit d60fc7b
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
4 changes: 2 additions & 2 deletions Core/XMPPMessage.h
Expand Up @@ -37,12 +37,12 @@
- (NSString *)type;
- (NSString *)subject;
- (NSString *)body;
- (NSString *)bodyWithLang:(NSString *)lang;
- (NSString *)bodyForLanguage:(NSString *)language;
- (NSString *)thread;

- (void)addSubject:(NSString *)subject;
- (void)addBody:(NSString *)body;
- (void)addBody:(NSString*)body withLang:(NSString*)lang;
- (void)addBody:(NSString *)body withLanguage:(NSString *)language;
- (void)addThread:(NSString *)thread;

- (BOOL)isChatMessage;
Expand Down
40 changes: 20 additions & 20 deletions Core/XMPPMessage.m
Expand Up @@ -163,29 +163,25 @@ - (NSString *)body
return [[self elementForName:@"body"] stringValue];
}

- (NSString*)bodyWithLang:(NSString*)lang
- (NSString *)bodyForLanguage:(NSString *)language
{
if (lang == nil)
if ([language length] == 0)
{
return [self body];

This comment has been minimized.

Copy link
@bmatasar

bmatasar Nov 13, 2013

This is wrong! Your changes return the first found, whereas nil language would mean the body with no xml:lang attribute

This comment has been minimized.

Copy link
@ObjColumnist

ObjColumnist Nov 14, 2013

Author Collaborator

Apologies I changed my mind on behaviour midway through.

If the language isn't found it now returns nil.
If the language is nil it only returns the body with no lang.

NSArray *bodies = [self elementsForName:@"body"];
if (bodies == nil)
return nil;
for (int i = 0; i < bodies.count; i++)
}

NSString *bodyForLanguage = nil;

for (NSXMLElement *bodyElement in [self elementsForName:@"body"])
{
DDXMLElement *elem = [bodies objectAtIndex:i];
DDXMLNode *langAttr = [elem attributeForName:@"lang"];
if (lang == nil)
{
if (langAttr == nil)
return [elem stringValue];
}
else
if ([language isEqualToString:[[bodyElement attributeForName:@"xml:lang"] stringValue]])
{
if ([lang isEqualToString:[langAttr stringValue]])
return [elem stringValue];
bodyForLanguage = [bodyElement stringValue];
break;
}
}
return nil;

return bodyForLanguage;
}

- (NSString *)thread
Expand All @@ -205,11 +201,15 @@ - (void)addBody:(NSString *)body
[self addChild:bodyElement];
}

- (void)addBody:(NSString *)body withLang:(NSString *)lang
- (void)addBody:(NSString *)body withLanguage:(NSString *)language
{
NSXMLElement *bodyElement = [NSXMLElement elementWithName:@"body" stringValue:body];
if (lang)
[bodyElement addAttributeWithName:@"xml:lang" stringValue:lang];

if ([language length])
{
[bodyElement addAttributeWithName:@"xml:lang" stringValue:language];
}

[self addChild:bodyElement];
}

Expand Down

0 comments on commit d60fc7b

Please sign in to comment.