Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

no timeout when connecting #122

Closed
jonasman opened this Issue Nov 6, 2012 · 2 comments

Comments

Projects
None yet
2 participants

jonasman commented Nov 6, 2012

the connection is done using : [asyncSocket connectToHost:host onPort:port error:errPtr];

So no timeout is set.

The problem is that sometimes the stream does not connect and we don't get any error, this could be useful for the reconnect module to attempt a reconnect after an unsuccessful connection.

I recommend to change it to the following method

  • (BOOL)connectToHost:(NSString )host
    onPort:(uint16_t)port
    withTimeout:(NSTimeInterval)timeout
    error:(NSError *
    )errPtr:

icewind commented Nov 22, 2012

+1 for timeout

As a work around you can connect with the reconnect module :)

@davidchiles davidchiles pushed a commit to davidchiles/XMPPFramework that referenced this issue Jan 26, 2016

@ObjColumnist ObjColumnist XMPPStream Connect APIs now have optional timeout parameter
Fixes #59
Fixes #122
f563206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment