Fix node creation when using options dictionary #143

Merged
merged 1 commit into from Apr 2, 2013

Projects

None yet

2 participants

@paulmelnikow
Contributor
  1. Create node should precede configure node instead of following it
  2. The values in the options dictionary should be the option values, and the keys the field names, instead of reversed

The current version of -createNode:WithOptions: works correctly only when there are no options, since the <configure> node is then omitted entirely.

I tested this on two servers (ejabberd and jabberd2) and had the same problem: both return a 501 feature-not-implemented when the <configure> element appears before the <create> element.

I tested the fix with ejabberd.

@paulmelnikow paulmelnikow Fix node creation when using options dictionary
1. Create node should precede configure node instead of following it
2. The values in the options dictionary should be the option values, and the keys the field names, instead of reversed
509d50a
@robbiehanson robbiehanson merged commit 8d28b2e into robbiehanson:master Apr 2, 2013
@paulmelnikow
Contributor

Thanks!

@paulmelnikow paulmelnikow deleted the paulmelnikow:pullreq1 branch Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment