Skip to content

Conversation

@connorferster
Copy link
Collaborator

  • Added ability for Geometry.align_center() and CompoundGeometry.align_center() to accept an x, y coordinate as a valid input.
  • Added tests for Geometry.align_center()

…align_center() to align to a x, y coordinate; Tests: Added tests for Geometry.align_center()
@connorferster
Copy link
Collaborator Author

connorferster commented Aug 21, 2022

As I was working on my sectionproperties lesson, I realized that I really wanted the ability to align geometries specific nodes on other geometries.

Don't know what's going on here, though:
image

Did something change with the GitHub actions script?

@robbievanleeuwen
Copy link
Owner

Thanks for this @connorferster, will have a look at this tomorrow!

Copy link
Owner

@robbievanleeuwen robbievanleeuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @connorferster, I think we just need to add a bit more info in the align_center() docstrings to describe the new feature, i.e. the argument description in Geometry and the docstring description for both Geometry and CompoundGeometry.

@robbievanleeuwen
Copy link
Owner

Did something change with the GitHub actions script?

Fixed this, changed the package dependencies a bit and forgot the pytest module 🤦

@connorferster
Copy link
Collaborator Author

Looks good @connorferster, I think we just need to add a bit more info in the align_center() docstrings to describe the new feature, i.e. the argument description in Geometry and the docstring description for both Geometry and CompoundGeometry.

Agreed! I missed some. Just added.

@connorferster connorferster merged commit 204be8c into master Aug 23, 2022
@connorferster connorferster deleted the align_to_points branch August 23, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants