Skip to content
Browse files

agnoster theme shows error code instead of an "x"

  • Loading branch information...
1 parent 73f7770 commit f09af5717923cca4e5c538e14846ea4816295949 Fuad Saud committed
Showing with 4 additions and 4 deletions.
  1. +4 −4 themes/agnoster.zsh-theme
View
8 themes/agnoster.zsh-theme
@@ -73,7 +73,7 @@ prompt_git() {
if $(git rev-parse --is-inside-work-tree >/dev/null 2>&1); then
ZSH_THEME_GIT_PROMPT_DIRTY='±'
dirty=$(parse_git_dirty)
- ref=$(git symbolic-ref HEAD 2> /dev/null) || ref="➦ $(git show-ref --head -s --abbrev |head -n1 2> /dev/null)"
+ ref=$(git symbolic-Fref HEAD 2> /dev/null) || ref="➦ $(git show-ref --head -s --abbrev |head -n1 2> /dev/null)"
@mbulat
mbulat added a note

Looks like a typo here as well, should be:

git symbolic-ref HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
if [[ -n $dirty ]]; then
prompt_segment yellow black
else
@@ -95,7 +95,7 @@ prompt_dir() {
prompt_status() {
local symbols
symbols=()
- [[ $RETVAL -ne 0 ]] && symbols+="%{%F{red}%}"
+ [[ $RETVAL -ne 0 ]] && symbols+="%{%F{red}%}$RETVAL"

IMHO this should become an option, rather than a default. I prefer having an "x". So far, I have not been concerned about exit codes; I was only interested in knowing whether a command failed or not.

@mbulat
mbulat added a note

Not sure why you would even want "x" as an option. A red return code is just as terse and supplies more information. If you care about the exit status at all, then you probably need the return code.

That's exactly what I thought @mbulat

I even think the error code gives a better look for the prompt (I don't really like that 'x').

But like I said before, it's not essential, so if people really disagree, this merge should be undone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
[[ $UID -eq 0 ]] && symbols+="%{%F{yellow}%}⚡"
[[ $(jobs -l | wc -l) -gt 0 ]] && symbols+="%{%F{cyan}%}⚙"
@@ -106,10 +106,10 @@ prompt_status() {
build_prompt() {
RETVAL=$?
prompt_status
- prompt_context
+ prompt_contextx

This change breaks the theme, I think it should be:

prompt_context
@sletix
sletix added a note

+

Same here, +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
prompt_dir
prompt_git
prompt_end
}
-PROMPT='%{%f%b%k%}$(build_prompt) '
+PROMPT='%{%f%b%k%}$(build_prompt) '

1 comment on commit f09af57

@jabbber

囧, too young

Please sign in to comment.
Something went wrong with that request. Please try again.