History completion broken #1479

Closed
ivan-krukov opened this Issue Dec 8, 2012 · 17 comments

Comments

Projects
None yet

Since my last merge (about 4 days ago now), the history completion with the up key is not working.
Instead of the ohmyzsh marvel, I get the bland bash "scroll one history item up" thing.
Trying to manually reset the key bindings in .zshrc does not work.
Affects both my machines with OSX and linux.
Any suggestions or finger-pointing on the guilty commiter are welcome.

daubman commented Dec 10, 2012

I am also experiencing this (after the recent round of updates) under OS X 10.8.2 - in addition to history search no longer working, some other plugins such as git/svn no longer reliably work. Is there a way to enable logging, etc..?

In the past, issues like this have occurred due to specific ordering requirements for plugins, however, I have not been able to find any docs on ordering (or how to determine)...

jvf commented Dec 10, 2012

For Workaround on Linux see: #1433

envoked commented Dec 10, 2012

@ivan-kryukov I was running into the same issue and after playing a little with the plugins I had enabled, it seems vi-mode is causing it.

daubman commented Dec 10, 2012

@envoked Oh no! It's great to have found the culprit, but I love vi-mode...
Any word on a workaround to keep these two compatible?

Confirming that history does not work with:
plugins=(vi-mode svn git osx python history-substring-search)

But DOES work with:
plugins=(svn git osx python history-substring-search)

Some history (unfortunately re-ordering is no longer the fix!):
#800

envoked commented Dec 10, 2012

Since I'm not too familiar with the internals of zsh, I ended up reverting vi-mode.plugin.zsh to https://github.com/robbyrussell/oh-my-zsh/blob/b609aa0e6c981f2039d777687cb01a84587f6edc/plugins/vi-mode/vi-mode.plugin.zsh and it seemed to do the trick.

Contributor

simeonwillbanks commented Dec 11, 2012

@ivan-kryukov Thanks for diagnosing the issue.

@envoked Reverting vi-mode works. Thank you all kindly for the feedback. I will try to find the exact cause in the near future.

@johnliu johnliu added a commit to johnliu/oh-my-zsh that referenced this issue Dec 19, 2012

@johnliu johnliu Temporary fix for #1479 5cb1b92

@gberenfield gberenfield pushed a commit to gberenfield/oh-my-zsh that referenced this issue Jan 3, 2013

Greg Berenfield Fix the fix for Issue #1479 93c90a6
Owner

robbyrussell commented Jan 11, 2013

I've merged n #1534. Does this resolve it for you?

👍

@agrimaldi agrimaldi added a commit to agrimaldi/oh-my-zsh that referenced this issue Jan 11, 2013

@agrimaldi agrimaldi Merge remote-tracking branch 'upstream/master'
* upstream/master: (35 commits)
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  Unset `config_file` variable in oh-my-zsh.sh
  Added a `migrate` alias.
  use lazy load for virtualenvwrapper
  Update plugins/sublime/sublime.plugin.zsh
  Fixes for vi-mode terminal overwriting bugs
  git plugin: Add `gpoat` alias
  fix typo in cd-wrapper
  Add branch status support to git_prompt_status
  Adding a symfony plugin, for symfony 1
  added 'gcl'for 'git config --list'; and gd for 'git diff'
  Bwana plugin for reading man pages in Safari
  check for knife.rb in cwd
  ...
54134b9

@ornicar ornicar added a commit to ornicar/oh-my-zsh that referenced this issue Jan 20, 2013

@ornicar ornicar Merge branch 'master' of git://github.com/robbyrussell/oh-my-zsh
* 'master' of git://github.com/robbyrussell/oh-my-zsh:
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  More usable and shorter aliases
  Add option to disable status notification
  Added subcommands for leiningen 1.7.0
  blinks theme works with light and dark Solarized
  sprunge-plugin: Remove the unnecessary while loop.
  Fix the behaviour of the sprunge plugin so that is preserves whitespaces and tabs.
cc046ef

@tunix tunix pushed a commit to tunix/oh-my-zsh that referenced this issue Jan 21, 2013

Alper Kanat Merge branch 'master' of git://github.com/robbyrussell/oh-my-zsh
* 'master' of git://github.com/robbyrussell/oh-my-zsh: (173 commits)
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  Unset `config_file` variable in oh-my-zsh.sh
  Added a `migrate` alias.
  Fix prompt color: Change it back to green
  plugin last-working-dir: create cache-directory if it doesn't exist
  Print last exit status in mortalscumbag prompt
  urltools for Everyone
  Backwards Compatible Jira URLs #1378
  use lazy load for virtualenvwrapper
  hg_current_branch added to mercurial plugin
  Fixing conflict in install scripts
  Fixed Kernel Detection in battery plugin
  ...

Conflicts:
	plugins/sublime/sublime.plugin.zsh
	plugins/svn/svn.plugin.zsh
b6a20e5

@mikesplain mikesplain added a commit to mikesplain/oh-my-zsh that referenced this issue Jan 23, 2013

@mikesplain mikesplain Merge branch 'master' of git://github.com/robbyrussell/oh-my-zsh
* 'master' of git://github.com/robbyrussell/oh-my-zsh:
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  More usable and shorter aliases
  Add option to disable status notification
  Added subcommands for leiningen 1.7.0
  blinks theme works with light and dark Solarized
  sprunge-plugin: Remove the unnecessary while loop.
  Fix the behaviour of the sprunge plugin so that is preserves whitespaces and tabs.
c22fc85

@sankara sankara added a commit to sankara/oh-my-zsh that referenced this issue Jan 23, 2013

@sankara sankara Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  More usable and shorter aliases
  Add option to disable status notification
  Added subcommands for leiningen 1.7.0
  blinks theme works with light and dark Solarized
  sprunge-plugin: Remove the unnecessary while loop.
  Fix the behaviour of the sprunge plugin so that is preserves whitespaces and tabs.
194de56

@wnkz wnkz added a commit to wnkz/oh-my-zsh that referenced this issue Jan 27, 2013

@wnkz wnkz Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  More usable and shorter aliases
  Add option to disable status notification
  Added subcommands for leiningen 1.7.0
  blinks theme works with light and dark Solarized
  sprunge-plugin: Remove the unnecessary while loop.
  Fix the behaviour of the sprunge plugin so that is preserves whitespaces and tabs.
1d0ea72

@tunix tunix pushed a commit to tunix/oh-my-zsh that referenced this issue Feb 3, 2013

Alper Kanat Merge branch 'master' of github.com:tunix/oh-my-zsh
* 'master' of github.com:tunix/oh-my-zsh: (174 commits)
  added motd plugin
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  Unset `config_file` variable in oh-my-zsh.sh
  Added a `migrate` alias.
  Fix prompt color: Change it back to green
  plugin last-working-dir: create cache-directory if it doesn't exist
  Print last exit status in mortalscumbag prompt
  urltools for Everyone
  Backwards Compatible Jira URLs #1378
  use lazy load for virtualenvwrapper
  hg_current_branch added to mercurial plugin
  Fixing conflict in install scripts
  ...
0002293

@dukex dukex pushed a commit to dukex/oh-my-zsh that referenced this issue Feb 4, 2013

Greg Berenfield + Duke Fix the fix for Issue #1479 2a4b490

@freecastle freecastle added a commit to freecastle/oh-my-zsh that referenced this issue Feb 14, 2013

@freecastle freecastle Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Fix rbenv gems helper
  add alias for rspec to zeus plugin
  added pj.plugin
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  More usable and shorter aliases
  Add option to disable status notification
  Added subcommands for leiningen 1.7.0
  blinks theme works with light and dark Solarized
  sprunge-plugin: Remove the unnecessary while loop.
  Fix the behaviour of the sprunge plugin so that is preserves whitespaces and tabs.
0956154

@sirech sirech pushed a commit to sirech/oh-my-zsh that referenced this issue Feb 14, 2013

Mario Fernandez Merge branch 'master' into devel
* master: (176 commits)
  Fix rbenv gems helper
  add alias for rspec to zeus plugin
  added pj.plugin
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  Unset `config_file` variable in oh-my-zsh.sh
  Added a `migrate` alias.
  Fix prompt color: Change it back to green
  plugin last-working-dir: create cache-directory if it doesn't exist
  Print last exit status in mortalscumbag prompt
  urltools for Everyone
  Backwards Compatible Jira URLs #1378
  use lazy load for virtualenvwrapper
  ...

Conflicts:
	plugins/rvm/rvm.plugin.zsh
6e6d395

@korjavin korjavin added a commit to korjavin/oh-my-zsh that referenced this issue Feb 16, 2013

@korjavin korjavin Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
* 'master' of https://github.com/robbyrussell/oh-my-zsh: (206 commits)
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  Unset `config_file` variable in oh-my-zsh.sh
  Added a `migrate` alias.
  Fix prompt color: Change it back to green
  plugin last-working-dir: create cache-directory if it doesn't exist
  Print last exit status in mortalscumbag prompt
  urltools for Everyone
  Backwards Compatible Jira URLs #1378
  use lazy load for virtualenvwrapper
  hg_current_branch added to mercurial plugin
  Fixing conflict in install scripts
  Fixed Kernel Detection in battery plugin
  ...
d0375b8

@julianwachholz julianwachholz added a commit to julianwachholz/oh-my-zsh that referenced this issue Feb 19, 2013

@julianwachholz julianwachholz Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
* 'master' of https://github.com/robbyrussell/oh-my-zsh:
  Fix rbenv gems helper
  add alias for rspec to zeus plugin
  added pj.plugin
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  More usable and shorter aliases
  Add option to disable status notification
  Added subcommands for leiningen 1.7.0
  blinks theme works with light and dark Solarized
  sprunge-plugin: Remove the unnecessary while loop.
  Fix the behaviour of the sprunge plugin so that is preserves whitespaces and tabs.
08c4ed9

@ahluntang ahluntang added a commit to ahluntang/oh-my-zsh that referenced this issue Feb 21, 2013

@ahluntang ahluntang Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  More usable and shorter aliases
  Add option to disable status notification
  Added subcommands for leiningen 1.7.0
  blinks theme works with light and dark Solarized
  sprunge-plugin: Remove the unnecessary while loop.
  Fix the behaviour of the sprunge plugin so that is preserves whitespaces and tabs.
3048cc8

@gerardo gerardo added a commit to gerardo/oh-my-zsh that referenced this issue Apr 22, 2013

@gerardo gerardo Merge branch 'master' of git://github.com/robbyrussell/oh-my-zsh
* 'master' of git://github.com/robbyrussell/oh-my-zsh: (173 commits)
  Adding MIT-LICENSE Closes #655
  Fix the fix for Issue #1479
  fix for Issue 1479
  Fixes #1489
  add unbundled command
  Revert "agnoster theme shows error code instead of an "x""
  Add Stash toogle to display if there's some stash or not in `git_prompt_status`
  fixes #1474 add zeus to bundle exec listx
  use feature names instead of failing branch names in "git flow feature"
  Unset `config_file` variable in oh-my-zsh.sh
  Added a `migrate` alias.
  Fix prompt color: Change it back to green
  plugin last-working-dir: create cache-directory if it doesn't exist
  Print last exit status in mortalscumbag prompt
  urltools for Everyone
  Backwards Compatible Jira URLs #1378
  use lazy load for virtualenvwrapper
  hg_current_branch added to mercurial plugin
  Fixing conflict in install scripts
  Fixed Kernel Detection in battery plugin
  ...
cbc2e2f

@jstnlef jstnlef added a commit to jstnlef/oh-my-zsh that referenced this issue May 7, 2013

@jstnlef Greg Berenfield + jstnlef Fix the fix for Issue #1479 50614a9

aktau commented Aug 3, 2013

To be honest I'm still experiencing this issue on OSX 10.7.5, everything default, the only thing I added was vi-mode to plugins...

I'm also still having this issue on OSX 10.8.2. oh-my-zsh version is up to date.

With vi-mode enabled bindkey is reporting "^[[A" up-line-or-history / "^[[B" down-line-or-history.

Reverting the vi-mode plugin as mentioned by @envoked still works.

@jtzemp jtzemp pushed a commit to jtzemp/oh-my-zsh that referenced this issue Sep 24, 2013

Greg Berenfield + JT Zemp Fix the fix for Issue #1479 b1acc36

I am having this problem on Debian Jessie 2014-02-20. Removing vi-mode resolved the issue. :S

prat0318 commented Mar 3, 2014

@envoked the plugin you mentioned works with arrow keys in insert mode. Can i somehow make it work with hjkl in normal mode (it simply gives the one-item history up/down that way) ?

I'm having this issue as well (also works when I comment out set -o vi and bindkey -v).

For the time being I've just mapped history-beginning-search-backward search to some other key :/

@w31 w31 pushed a commit to w31/oh-my-zsh that referenced this issue Apr 30, 2014

Greg Berenfield Fix the fix for Issue #1479 2524738

uorbe001 commented May 8, 2014

I started having this issue recently, and I found out reverting vi-mode to 003dd8f fixes the issue, the bug was introduced on this commit: 93c90a6#diff-4569f6ca7bb9168bf4bd700779e8baba.

To be honest, I don't know what that change is about, I figured maybe @gberenfield can have a look at why this would come back after his change?

New zsh user here. I was having this same issue on a new setup. Adding:

bindkey '^[[A' history-substring-search-up
bindkey '^[[B' history-substring-search-down

... to my .zshrc after plugins seems to have fixed it. (Also have history-substring-search in my plugins after vi-mode).

Seems a bit redundant but got it working for me. (This is on osx 10.9.2).

ivan-krukov closed this May 9, 2014

YesCT commented Jun 7, 2014

just added

bindkey '^R' history-incremental-search-backward

after the plugins,
per http://unix.stackexchange.com/a/44118

@kenton kenton added a commit to kenton/oh-my-zsh that referenced this issue Jan 9, 2015

@kenton Greg Berenfield + kenton Fix the fix for Issue #1479 6c304bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment