auto-correcting sucks hard #534

Closed
c2h2 opened this Issue Aug 8, 2011 · 62 comments
@c2h2

the auto correcting always convert like ddd -> dd, very annoying, can we disable auto correcting by default?

@pstadler
unsetopt correct_all

should do it.

@robbyrussell

You can set some custom overrides for commands you use most often... but this feature will stay on by default (until I'm convinced it's annoying).

Check out this file for more details... you can set overrides in custom to your heart's content.

@Frost

I think setopt correct would be a much more sensible default setting. setopt correctall will for example try to automatically correct any word in a command to some file or whatever else it'll find in your autocomplete path (user home-dirs, servers from .ssh/config, etc).

At least it's not autocorrect, or I probably would've started a damnyouzshcorrectall.com site by now ;p

@isimmons

It is annoying. On Ubuntu I installed 'tree' and then try to run it and it asks every time if I want it to correct to 'tee'. Now why would I want it to do that? :-) Thanks for an awesome shell but spell correct is for word processors, not terminals IMHO.

Thank you for the overrides info.

Thank you pstadler for the line to disable it. Dropped that in my .zshrc file and it turned that annoying thing off.

@sheerun

It's damn annoying.

@techmaniack

It is annoying 💩

@hrj
hrj commented Mar 5, 2013

🐸 Very annoying. Please disable auto correct all by default. I have tens of user profiles and I always get burned by this and it is annoying to have to disable it or to remember to disable it after creating a fresh user profile.

@trobrock

I really only find this annoying when using bundler binstubs, has anyone found any of of getting the correction system to support binstubs?

@BBonifield

Agreed that this is annoying. I think the more sensible default would be to have it off.

@tyro89

Agreed that this is annoying, keeps asking me if I want to correct git status to git stats...

@mjezzi

+1

@messick

👍

@filib

+1

@twaldecker

👍

@antitoxic

Definitely annoying.

@jeffdc

count me into the annoying camp

@tyro89

@robbyrussell I think this might be worth taking a look at again.

@paulkogel

After a recent oh-my-zsh update i keep getting auto correct suggestions despite having unsetopt correct_all in my .zshrc =(

@filib

@paulwittmann Likewise. I added the following to mine.

unsetopt correct_all
unsetopt correct
@paulkogel

@unsymbol thanks so much, works like a charm!

@bigeasy

Help! Help! Jane, stop this crazy thing! Jane!

@rummik

@isimmons What's more annoying is that Zsh doesn't pick up on newly installed programs. Try tab-completing something you've just installed

@hrj
hrj commented Jun 5, 2013

@rummik That's a different issue. You can run rehash to let zsh find newly installed programs or PATH changes.

@hrj
hrj commented Jun 5, 2013

Is there a way to "star" issues on Github or somehow let the developers know that so many people are interested in an issue? Does the number of "watchers" show up to the developer?

@rummik

@hrj Hm. Hadn't known about rehash. Seems like a wrapper for various package managers that does a rehash afterward would be handy.

My point was more that @isimmons' problem with completion was because Zsh didn't know about the program he had just installed, so it was correcting him

@bigeasy

My concern about autocorrect behavior is that eventually, it will suggest something harmful, I'm not going to notice that my command has been rewritten, and I'm going to press enter. At that point it will have been my fault for having allowed autocorrect in the first place because that's what it does and that's the the ways it's always been.

See: http://www.catb.org/jargon/html/D/DWIM.html

@0X1A

+1

@frosty

+1

@nicatronTg

👍

@filib

👍

@messick

👍

@BBonifield

@robbyrussell It seems that there is still a number of people that would prefer a change. Are you convinced that it's annoying yet?

@Domon

👍

@0X1A

@BBonifield Doubtful, this thread is 2 years old and it's still in.

@messick

@0x1A We need to stay strong. Change only comes to those who continue to fight for what is right.

@Profpatsch

👍

@tsalzer

Please disable or remove autocorrect by default.

@NobbZ
@rummik

Because it's so hard to type print "unsetopt correct\nunsetopt correct_all" >> ~/.zshrc

@sheerun

@rummik It's the only thing that annoys me in out of the box oh-my-zsh configuration. And of course it's hard to type, you need to google for it.

@rummik

@sheerun man zshoptions

@hrj

It's not just about the inconvenience of changing the defaults. The bigger problem is, the defaults are dangerous! OMZSH changes my command in a very unintuitive and unexpected way. I have, on occasions, deleted files due to this feature when I was new to OMZSH. Luckily, those files were version controlled, and I learnt the options to disable auto correct.

These days, I don't bother installing OMZSH into new user profiles. Of course, since it is open-source, I could fork it. But I am now wary of using such a tool, given that the creators are blind to potentially destructive features.

(sigh) I did like the project once upon a time.

@0X1A

@hrj I agree with you man, there's been too many times where the autocorrect is something completely unrelated and I press enter out of muscle memory. It's pretty annoying but I don't think it'll end up getting changed anytime soon.

@robbyrussell
Owner

Admittedly, I don't think I've seen this thread since I closed it. I typically only look at pull-requests.

Who wants to send one..?

@BBonifield

@robbyrussell Pull request added, comments appreciated!

@nicatronTg

Thank. God.

@BBonifield

@robbyrussell Thanks for the quick merge!

@messick

I feel as a shadow has been lifted from my soul. Our long dark nightmare is finally over! Congratulations everybody!

@mablae

Awsome! Finally!

@Drarok

So this is why auto-correct stopped working!

@unphased

@Drarok Ha, yeah looks like it.

You know I would leave it on if it was actually smart.

For example:

gitf etch --> git etch

Dammit, be smarter!!

I'm kind of not serious. enabling correction to mess with the arguments is probably not a safe thing to do.

I guess i'm switching it back off now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment