Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki: Feedback request for my big update of the themes page #8078

Closed
Kovah opened this issue Aug 13, 2019 · 11 comments
Closed

Wiki: Feedback request for my big update of the themes page #8078

Kovah opened this issue Aug 13, 2019 · 11 comments
Labels
Discussion Discussion or RFC issue Feature New feature or request

Comments

@Kovah
Copy link

Kovah commented Aug 13, 2019

Hi there,

the current theme overview has a lot of interesting themes but looks quite chaotic. Screenshots are available in many different sizes, some with the terminal window, some not and - most important - every one with another color scheme. This makes it very hard to compare the different features and structure of the themes.

So, I reset my Terminal to default settings, started up Automator and generated standardized screenshots for almost all of the current themes.
5 themes had issues with missing dependencies so I left them out for now.

Page Preview

👉 Preview of the page in a fork of the wiki

Preview of a screenshot

robbyrussell

Screenshot setup

The screenshots were generated on macOS Mojave (10.14.5) with the macOS Terminal app. The used theme is Basic with the default settings and colors. The font was switched to Fira Code at 13 pt to enable some special characters in certain themes. All terminal windows have a size of 100x31. I ran two short commands in a prepared folder with a pseudo project structure and Git enabled.

If you agree with the update I will merge my changes into your wiki. 😊

@Kovah Kovah added the Feature New feature or request label Aug 13, 2019
@Kovah Kovah changed the title Wiki: Feedback for big update of the themes page Wiki: Feedback request for my big update of the themes page Aug 19, 2019
@Kovah
Copy link
Author

Kovah commented Aug 27, 2019

Any chance for a quick Go or No Go? 😊

@mcornella
Copy link
Member

Hi Kevin, thank you for this. The thing is that each theme needs to present the different features it has, that's why I'm hesitant to go ahead with this. I realize preserving the steps of the old screenshots is a time-consuming task but it's an important part of showcasing each theme.

As per color-scheme and window size, perhaps we could enforce a particular size but the color-scheme is also part of what each theme author wants to show as the "best" option to go with that particular theme.

The resulting wiki looks better though, don't throw it away just yet.

@mcornella mcornella added the Discussion Discussion or RFC issue label Aug 27, 2019
@mcornella mcornella pinned this issue Aug 27, 2019
@Kovah
Copy link
Author

Kovah commented Aug 27, 2019

Thank you for the feedback. Totally understand the point and will think about a possible solution for that.

@Kovah
Copy link
Author

Kovah commented Sep 3, 2019

So, I wrote a blog post about the process and made both the test files and the Automator script available. This way anyone (with macOS) can replicate the screenshots.

@mfdorst
Copy link
Contributor

mfdorst commented Oct 4, 2019

I for one am really glad you made this. I've often wished there were an apples-to-apples comparison of what these themes would look like on a basic black-background terminal.

I'm not sure if this is possible on the wiki page, but if there were a way to toggle back and forth between the "basic" and "custom" version of these screenshots, that might help address the issue. I think the current version should probably be the one shown by default, simply because when scrolling through your version of the wiki, none of the themes really stand out much from each other. However, once you've narrowed it down to two or three themes you like, it could then be really helpful to look at them side-by-side with an identical color-scheme.

@mcornella mcornella unpinned this issue Nov 15, 2019
@mcornella mcornella pinned this issue Feb 5, 2020
@larson-carter
Copy link
Member

@Kovah
Do you think that you could join our discord server so we could continue working on this problem?

One of the things on our agenda is updating the wiki with new consistent screenshots.

@Kovah
Copy link
Author

Kovah commented May 13, 2020

Sure, I joined already.

@Kovah
Copy link
Author

Kovah commented Aug 17, 2020

Quick update for everyone: we discussed ways to improve the screenshot generation and the last idea way to pull theme-specific details out of the theme files to generate screens based on them. This is quite difficult. I proposed to add the current screens with the same features as a new wiki page aside the current theme page.

@mcornella
Copy link
Member

Alright I put the new themes page as the default and linked to the old one from there. Thanks for your work and patience!

@mcornella mcornella unpinned this issue Sep 16, 2020
@Kovah
Copy link
Author

Kovah commented Sep 16, 2020

Awesome!
Maybe you could add my repo with the screenshot generation files and guide at the bottom so everyone knows how the screens were generated. Will update the instructions later.
https://github.com/Kovah/oh-my-zsh-screenshot-generation

@mcornella
Copy link
Member

Done! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Discussion or RFC issue Feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants