Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki: Feedback request for my big update of the themes page #8078

Open
Kovah opened this issue Aug 13, 2019 · 4 comments

Comments

@Kovah
Copy link

commented Aug 13, 2019

Hi there,

the current theme overview has a lot of interesting themes but looks quite chaotic. Screenshots are available in many different sizes, some with the terminal window, some not and - most important - every one with another color scheme. This makes it very hard to compare the different features and structure of the themes.

So, I reset my Terminal to default settings, started up Automator and generated standardized screenshots for almost all of the current themes.
5 themes had issues with missing dependencies so I left them out for now.

Page Preview

👉 Preview of the page in a fork of the wiki

Preview of a screenshot

robbyrussell

Screenshot setup

The screenshots were generated on macOS Mojave (10.14.5) with the macOS Terminal app. The used theme is Basic with the default settings and colors. The font was switched to Fira Code at 13 pt to enable some special characters in certain themes. All terminal windows have a size of 100x31. I ran two short commands in a prepared folder with a pseudo project structure and Git enabled.

If you agree with the update I will merge my changes into your wiki. 😊

@Kovah Kovah added the Type: feature label Aug 13, 2019

@Kovah Kovah changed the title Wiki: Feedback for big update of the themes page Wiki: Feedback request for my big update of the themes page Aug 19, 2019

@Kovah

This comment has been minimized.

Copy link
Author

commented Aug 27, 2019

Any chance for a quick Go or No Go? 😊

@mcornella

This comment has been minimized.

Copy link
Collaborator

commented Aug 27, 2019

Hi Kevin, thank you for this. The thing is that each theme needs to present the different features it has, that's why I'm hesitant to go ahead with this. I realize preserving the steps of the old screenshots is a time-consuming task but it's an important part of showcasing each theme.

As per color-scheme and window size, perhaps we could enforce a particular size but the color-scheme is also part of what each theme author wants to show as the "best" option to go with that particular theme.

The resulting wiki looks better though, don't throw it away just yet.

@mcornella mcornella pinned this issue Aug 27, 2019

@Kovah

This comment has been minimized.

Copy link
Author

commented Aug 27, 2019

Thank you for the feedback. Totally understand the point and will think about a possible solution for that.

@Kovah

This comment has been minimized.

Copy link
Author

commented Sep 3, 2019

So, I wrote a blog post about the process and made both the test files and the Automator script available. This way anyone (with macOS) can replicate the screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.