Accept alternate install paths via ZSH variable #1085

Merged
merged 4 commits into from Mar 13, 2014

Projects

None yet

3 participants

@avit

I added an option to use the ZSH environment variable at install-time to set the destination.

For example I like to keep things like oh-my-zsh as submodules under my .dotfiles.

@avit

I've rebased this to your master again, let me know if you still want to merge it.

Part of #1086 which depends on this, but it's a separate issue so you can merge it independently.

@avit

@robbyrussell I've just rebased this too, please comment, merge, or close.

@robbyrussell
Owner

@avit Can you move the README details under the "manual" section? I want to keep the suggested/easy way simple for folks.

@mcornella
Collaborator

Hi! Right now the install script already supports changing the directory; the only change necessary is in the README file.

I think its place is in the "automatic" section since using the manual way you don't install it running install.sh but rather using git clone, where you can specify the output directory.

I do suggest changing the command though, using export before running the script. Something like this:

optional: change install directory

You can change the install directory if you run export ZSH=<path to directory> before you run the install script.

though I don't know if export is platform or shell independent.

@avit

Sorry, I lost track of this ticket... thanks for the bump. I'll take a look and clean it up so we can close it.

@robbyrussell
Owner

@avit How's this coming along? :-)

@avit

Please see my questions on d4a9467#commitcomment-5609476

@avit

Right now the install script already supports changing the directory

No, it looks like master only checks if it's already installed in the ZSH location, and quits if it already exists. But it'll still clone to the default ~/.oh-my-zsh location.

I think its place is in the "automatic" section since using the manual way you don't install it running install.sh but rather using git clone, where you can specify the output directory.

Right, I agree. This is an option for the automatic installer which isn't used in the manual steps.

I do suggest changing the command though, using export before running the script.

I think this is only necessary because of the way d4a9467 was done, but if we prefer to document it using "export" on a separate line so the install.sh pipeline can be used unchanged as cut-and-paste from the README I'm fine with that. However:

  • sh, bash, ksh, etc. use export ZSH=value
  • csh, tcsh, etc. use setenv ZSH value

In any case, if someone is doing this, they probably know what they're doing.

@robbyrussell robbyrussell merged commit 9cb14dc into robbyrussell:master Mar 13, 2014
@avit avit deleted the avit:install-path branch Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment