Replace cp -verbose with rsync #1319

Merged
merged 1 commit into from Dec 2, 2012

Conversation

Projects
None yet
3 participants
@skatkov
Contributor

skatkov commented Sep 18, 2012

Found this solution somethere in internet. Very good way to track copy process while file is copying

Replace cp verbose with rsync
Rsync can help track progress while file is copying
@robbyrussell

This comment has been minimized.

Show comment Hide comment
@robbyrussell

robbyrussell Sep 23, 2012

Owner

If you can find a few people who think they'd benefit from this, I'll consider it.

Owner

robbyrussell commented Sep 23, 2012

If you can find a few people who think they'd benefit from this, I'll consider it.

robbyrussell added a commit that referenced this pull request Dec 2, 2012

Merge pull request #1319 from skatkov/master
Replace cp -verbose with rsync

@robbyrussell robbyrussell merged commit 245eee1 into robbyrussell:master Dec 2, 2012

w31 pushed a commit to w31/oh-my-zsh that referenced this pull request Apr 30, 2014

Merge pull request #1319 from skatkov/master
Replace cp -verbose with rsync
@mcornella

This comment has been minimized.

Show comment Hide comment
@mcornella

mcornella Feb 24, 2016

Collaborator

That will make it accept rsync options as well, which is why the -- was put in place. It should work fine, but apparently the rsync completion doesn't account for that, so it doesn't work. What we want instead is to force completion of cpv to only allow files. I'll look into it and put a PR in place.

Collaborator

mcornella commented on 55c6901 Feb 24, 2016

That will make it accept rsync options as well, which is why the -- was put in place. It should work fine, but apparently the rsync completion doesn't account for that, so it doesn't work. What we want instead is to force completion of cpv to only allow files. I'll look into it and put a PR in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment