Fix to restore bindings after switching to vi-mode #1320

Merged
merged 1 commit into from Sep 23, 2012

Projects

None yet

2 participants

@jimhester
Contributor

the vi-mode plugin destroys any bindings made before it is sourced due to the
'bindkey -v' call to switch to using vi-mode. This patch saves the bindings
before invoking 'bindkey -v' then rebinds them afterwards, this fixes a number
of outstanding issues due to people using vi-mode and having things in oh-my-zsh
break due to the bindings being destroyed

This fixes #1307 #817 #562 #800 and numerous other issues where the bindings are removed due to using the vi-mode. Using vi-mode as it is also removes a lot of the functionality provided by oh-my-zsh, because all the custom bindings are gone.

@jimhester jimhester Fix to restore bindings after switching to vi-mode
the vi-mode plugin destroys any bindings made before it is sourced due to the
'bindkey -v' call to switch to using vi-mode.  This patch saves the bindings
before invoking 'bindkey -v' then rebinds them afterwards, this fixes a number
of outstanding issues due to people using vi-mode and having things in oh-my-zsh
break due to the bindings being destroyed
b609aa0
@robbyrussell

@jimhester Which issues does this help resolve? Can you help identify those github issues so that we can close those now?

@robbyrussell robbyrussell merged commit 8247a40 into robbyrussell:master Sep 23, 2012
@mcornella mcornella referenced this pull request Mar 11, 2014
Closed

vi-mode plugin bug #1307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment