Add "agnoster" theme #1327

Merged
merged 4 commits into from Sep 29, 2012

Conversation

Projects
None yet
9 participants
@agnoster
Contributor

agnoster commented Sep 26, 2012

I know in general you don't want more themes, but you mentioned you might make an exception for this one (https://twitter.com/ohmyzsh/status/250400677522702336), so I thought I'd offer a pull request so you can decide.

I think this theme actually has a few novel things going for it. The one thing that I'd consider to be a real downside is that for the theme to work properly, a user must be using a Powerline-patched font. While these are readily available, and documented in the theme, the odds of a user simply changing their ZSH_THEME to "agnoster" and then being frustrated when it doesn't render properly could be considered too high.

Anyway, otherwise I think it's a quite delightful theme ;-). I'd prefer for there to be a cleaner way to browse and discover themes, and see their prerequisites clearly advertised.

It might be best to simply point people at the gist (https://gist.github.com/3712874), where the prereq is a bit clearer. Obviously it means more work to install, but since the user would need to install a font anyway, I don't think that's too great a burden. Probably better for you, at any rate, to have fewer people coming and complaining when the prompt doesn't render correctly! I know what a pain that can be.

But if you decide you just got to have it, you're very welcome to merge, as you see fit.

Cheers, and thanks for OMZ!

@To1ne

This comment has been minimized.

Show comment Hide comment
@To1ne

To1ne Sep 26, 2012

Contributor

@agnoster also provides an awesome screenshot in his Twitter timeline: http://twitter.com/i/#!/agnoster/media/slideshow?url=pic.twitter.com%2FGXS2JjNA

Contributor

To1ne commented Sep 26, 2012

@agnoster also provides an awesome screenshot in his Twitter timeline: http://twitter.com/i/#!/agnoster/media/slideshow?url=pic.twitter.com%2FGXS2JjNA

@janernsting

This comment has been minimized.

Show comment Hide comment
@janernsting

janernsting Sep 28, 2012

+1

I just manually added agnoster to my oh-my-zsh clone: this is the very first theme I actually like! So far I had stuck with the default theme.

From my point of view, adding the Powerline-patched font wasn't too much hassle. Even though it may be frustrating when you don't know that you're supposed to add that font.

+1

I just manually added agnoster to my oh-my-zsh clone: this is the very first theme I actually like! So far I had stuck with the default theme.

From my point of view, adding the Powerline-patched font wasn't too much hassle. Even though it may be frustrating when you don't know that you're supposed to add that font.

@To1ne

This comment has been minimized.

Show comment Hide comment
@To1ne

To1ne Sep 28, 2012

Contributor

Actually @jeremyFreeAgent also has a great powerline like theme (although for some reason I preferred @agnoster's).
In his README he refers to Powerline for vim which has a great wiki page filled with Powerline-enabled fonts.

Contributor

To1ne commented Sep 28, 2012

Actually @jeremyFreeAgent also has a great powerline like theme (although for some reason I preferred @agnoster's).
In his README he refers to Powerline for vim which has a great wiki page filled with Powerline-enabled fonts.

@jeremyFreeAgent

This comment has been minimized.

Show comment Hide comment
@jeremyFreeAgent

jeremyFreeAgent Sep 28, 2012

Hi, @To1ne what is making you like better @agnoster's one ? You can contribute or post issue to tell me what you want.

Hi, @To1ne what is making you like better @agnoster's one ? You can contribute or post issue to tell me what you want.

@agnoster

This comment has been minimized.

Show comment Hide comment
@agnoster

agnoster Sep 28, 2012

Contributor

@jeremyFreeAgent Probably just because the screenshots look nicer with solarized ;-)

FWIW, I think mine - at least the way it ended up - is more minimal, and focused on only showing what you need to know at a given point in time. That said, I like that you expose a bit more information about the git state. And incorporating date/time in an RPROMPT might be nice, I'm just worried about noise.

Also, the approach I took (eventually) should make it a lot easier to use my theme as a jumping-off point for others looking to make their own powerline-style prompts, since it provides easy functions for "drawing" each segment and doing the right transitions. Of course this makes the code a good deal weightier, but I think the readability/customizability is worth it.

What would actually be super cool is a baseline "powerline-theme.zsh" that could be used by either my or your theme, or other themes to come. Would slim our themes down considerably. Hmm... perhaps it could even detect and prompt the user if their font doesn't have the powerline glyphs. Any ideas about how that could be detected?

Contributor

agnoster commented Sep 28, 2012

@jeremyFreeAgent Probably just because the screenshots look nicer with solarized ;-)

FWIW, I think mine - at least the way it ended up - is more minimal, and focused on only showing what you need to know at a given point in time. That said, I like that you expose a bit more information about the git state. And incorporating date/time in an RPROMPT might be nice, I'm just worried about noise.

Also, the approach I took (eventually) should make it a lot easier to use my theme as a jumping-off point for others looking to make their own powerline-style prompts, since it provides easy functions for "drawing" each segment and doing the right transitions. Of course this makes the code a good deal weightier, but I think the readability/customizability is worth it.

What would actually be super cool is a baseline "powerline-theme.zsh" that could be used by either my or your theme, or other themes to come. Would slim our themes down considerably. Hmm... perhaps it could even detect and prompt the user if their font doesn't have the powerline glyphs. Any ideas about how that could be detected?

@agnoster

This comment has been minimized.

Show comment Hide comment
@agnoster

agnoster Sep 28, 2012

Contributor

@To1ne That screenshot is old ;-) Here's the new version (and the version that's in the pull request):

agnoster zsh theme screenshot

Note: the checkmark now doesn't show, on the theory that you should only see information that's different from the default. Ditto for user/hostname, background jobs indicator, just like git status generally is.

Contributor

agnoster commented Sep 28, 2012

@To1ne That screenshot is old ;-) Here's the new version (and the version that's in the pull request):

agnoster zsh theme screenshot

Note: the checkmark now doesn't show, on the theory that you should only see information that's different from the default. Ditto for user/hostname, background jobs indicator, just like git status generally is.

@danielbayerlein

This comment has been minimized.

Show comment Hide comment
@danielbayerlein

danielbayerlein Sep 28, 2012

Contributor

@agnoster Very nice 👍 I miss only the information of the Ruby version in the RPROMPT :wink2:

Contributor

danielbayerlein commented Sep 28, 2012

@agnoster Very nice 👍 I miss only the information of the Ruby version in the RPROMPT :wink2:

@To1ne

This comment has been minimized.

Show comment Hide comment
@To1ne

To1ne Sep 28, 2012

Contributor

@agnoster is a special font patch required for the cog symbol (background process running)?

Contributor

To1ne commented Sep 28, 2012

@agnoster is a special font patch required for the cog symbol (background process running)?

@To1ne

This comment has been minimized.

Show comment Hide comment
@To1ne

To1ne Sep 28, 2012

Contributor

@agnoster one thing I like about @jeremyFreeAgent's, is the way can configure the date and time aligned at the right.

Contributor

To1ne commented Sep 28, 2012

@agnoster one thing I like about @jeremyFreeAgent's, is the way can configure the date and time aligned at the right.

@paddykontschak

This comment has been minimized.

Show comment Hide comment
@paddykontschak

paddykontschak Sep 28, 2012

@To1ne You need to have one of the patched fonts from Vim-Powerline installed or patch your own.

@To1ne You need to have one of the patched fonts from Vim-Powerline installed or patch your own.

@endel

This comment has been minimized.

Show comment Hide comment
@endel

endel Sep 29, 2012

Freaking awesome theme.

endel commented Sep 29, 2012

Freaking awesome theme.

@robbyrussell

This comment has been minimized.

Show comment Hide comment
@robbyrussell

robbyrussell Sep 29, 2012

Owner

Let's do this... please update the wiki.

Owner

robbyrussell commented Sep 29, 2012

Let's do this... please update the wiki.

robbyrussell added a commit that referenced this pull request Sep 29, 2012

Merge pull request #1327 from agnoster/master
BY POPULAR DEMAND... the "agnoster" theme...

@robbyrussell robbyrussell merged commit 73f7770 into robbyrussell:master Sep 29, 2012

@agnoster

This comment has been minimized.

Show comment Hide comment
@agnoster

agnoster Sep 30, 2012

Contributor

Updated the Themes on the Wiki with the necessary instructions.

I've got a few updates locally, but I'll probably wait a while before filing a pull request to update, don't want to inundate you with busywork.

Thanks for the merge! Makes me feel warm and fuzzy inside. :-)

Contributor

agnoster commented Sep 30, 2012

Updated the Themes on the Wiki with the necessary instructions.

I've got a few updates locally, but I'll probably wait a while before filing a pull request to update, don't want to inundate you with busywork.

Thanks for the merge! Makes me feel warm and fuzzy inside. :-)

@sajoku

This comment has been minimized.

Show comment Hide comment
@sajoku

sajoku Oct 15, 2012

@agnoster really like the theme. Maybe you can put the updates in a repository of its own so I can pull those?

sajoku commented Oct 15, 2012

@agnoster really like the theme. Maybe you can put the updates in a repository of its own so I can pull those?

w31 pushed a commit to w31/oh-my-zsh that referenced this pull request Apr 30, 2014

Merge pull request #1327 from agnoster/master
BY POPULAR DEMAND... the "agnoster" theme...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment