Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Jira Plugin - Wrong URL :zap: #1347

Merged
merged 1 commit into from Dec 1, 2012

Conversation

Projects
None yet
3 participants
Contributor

paulredmond commented Oct 9, 2012

Apologies, you just merged 1335, but I had a typo in the URL :(

Contributor

paulredmond commented Nov 29, 2012

@robbyrussell mind giving this a look? I made a typo that causes this plugin to not work in the original PR.

robbyrussell added a commit that referenced this pull request Dec 1, 2012

@robbyrussell robbyrussell merged commit f9c1a72 into robbyrussell:master Dec 1, 2012

Owner

robbyrussell commented Dec 1, 2012

@paulredmond apologies for the delay!

Contributor

paulredmond commented Dec 2, 2012

@robbyrussell thanks for the merge...I can't believe I got the url wrong!

@paulredmond, few issues noticed.

  1. Its name.atlassian.net, not name.jira.com
  2. Open is not opening url's properly. I had to use /usr/bin/google-chrome $jira_url/browse/$1 locally to get it right. There is a SO question on the topic here
  3. It should be able to look up in the parent folders for the .jira-url file
Contributor

paulredmond commented Dec 30, 2012

@jaseemabid 1 doesn't matter, the URL is configured by you, the user. 2 probably only works on Mac OSX so perhaps you need to alias open, which is context-sensitive (ie. a URL pattern will open in your default browser). I might be able to add some OS detection but I'd have to research Linux more for similar functionality.

Feel free to send your own PR addressing 2/3

@paulredmond I didn't know that open is mac specific. Will see how I can get it done on linux. Another feature is to save the variable ABC in ABC-124. -> Leads to a lot less typing. ⚡️

xdg-open should do the trick.

w31 pushed a commit to w31/oh-my-zsh that referenced this pull request Apr 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment