don't populate the environment with variables which are only used by oh-my-zsh #149

Closed
wants to merge 4 commits into
from

Projects

None yet

4 participants

@Dieterbe
Contributor
Dieterbe commented Dec 1, 2010

No description provided.

@Dieterbe Dieterbe Don't export oh-my-zsh configuration paramaters to the environment
These variables are only used by oh-my-zsh, so there's no need
to populate the environment of all children with them.
1a673fc
@Dieterbe
Contributor
Dieterbe commented Dec 1, 2010

btw, the other commits (with my theme) are in an earlier pull request, which you'll probably merge as well. so there's no "commit pollution" ;-)

@Dieterbe Dieterbe Load theme after loading all libraries
By not loading the theme at the end of lib/appearance.zsh, but rather
after loading all libraries, a theme can rely on/override not just the basic
appearance stuff like PS1.
For example the 'dieter' theme intercepts (but does not alter) the accept-line
widget to change the display on the relevant keystroke.
Features like these are impossible or subject to race conditions without
this rearrangement.
7ca0afd
@mkomitee

Wouldn't you want to load the theme after the customizations in $ZSH/custom/*.zsh were loaded? I submitted a similar pull request doing just that before I saw this one.

robbyrussell#178

Owner

Not really, because in the custom files I can override theme behavior.
The used theme might not be written by me, and I might want to override certain stuff from it.

Understandable. I guess either I'm missing the purpose of custom, and should throw lots of what I put in there directly into a new lib, or this is just a chicken-and-egg problem inherent in the system.

@Dieterbe
Contributor

All commits except "1a673fc Don't export oh-my-zsh configuration paramaters to the environment" have been merged. so just this last one and we can close the deal.

@dserodio

I agree, no need to pollute the global namespace.

@Dieterbe
Contributor
Dieterbe commented May 2, 2011

@robbyrussell can you apply this? it's just one simple commit.
Dieterbe@1a673fc
just when you apply it, amend it and also remove the export for the DISABLE_AUTO_TITLE variable (this variable was added recently, long after I made this commit and pull request)

@robbyrussell
Owner

This has finally been merged in!

@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [#149] Merge alias into utility 4c73e33
@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [#149] Move diff, wdiff, make into their own files 1e662ae
@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [#149] Simplify diff, wdiff, make d31e4b1
@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [#149] Remove unnecessary if statements dff3b5b
@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [#149] Move compdef calls into their own files b59d560
@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [#149, Fix #98] Add documentation for alias d6dbe9c
@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [#149] Rename duh to dut d0df6f2
@indrajitr indrajitr added a commit to indrajitr/oh-my-zsh-legacy that referenced this pull request Aug 5, 2012
@sorin-ionescu @indrajitr sorin-ionescu + indrajitr [Fix #149] Restructure utility d87d096
@Dannyzen Dannyzen pushed a commit to Dannyzen/oh-my-zsh that referenced this pull request Apr 3, 2016
@danielshahaf danielshahaf README: make installation step 1 more accurate
Based on a patch by George Angelopoulos <george@usermod.net>.

Closes #149.
85b3446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment