Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Use zsh's default setting for ':completion:*:hosts' #1498

Closed
wants to merge 1 commit into from

2 participants

@blueyed

The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.
ef002a8
@blueyed

This has not really been merged - the pull request was closed from a wrong commit message (fb3dc24).

@robbyrussell
Please re-open and apply this. This is likely to cause a conflict now when merging, e.g. because of having merged #690 . It should be trivial to resolve though.

@swanandp

The commit should have actually referred #1489 but instead it refers #1498.

@tnb tnb referenced this pull request from a commit in tnb/oh-my-zsh
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
25c6238
@chrissearle chrissearle referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@mchataigner mchataigner referenced this pull request from a commit in mchataigner/oh-my-zsh
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
342c76f
@Raytray Raytray referenced this pull request from a commit
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
9f85301
@blueyed

@robbyrussell please re-open the issue. It has been closed via wrong commit messages.

@mcginleyr1 mcginleyr1 referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@jtzemp jtzemp referenced this pull request from a commit in jtzemp/oh-my-zsh
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
1d259d0
@blueyed blueyed referenced this pull request from a commit in blueyed/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
71d9420
@blueyed

Closing in favor of #2602 - the same, but rebased.

@blueyed blueyed deleted the blueyed:use-default-hosts-completion branch
@apoh apoh referenced this pull request from a commit in apoh/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
0c73c41
@neiljdo neiljdo referenced this pull request from a commit in neiljdo/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
113c231
@w31 w31 referenced this pull request from a commit in w31/oh-my-zsh
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
dc703a4
@w31 w31 referenced this pull request from a commit in w31/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
6eb3511
@stvleung stvleung referenced this pull request from a commit
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
39f54e5
@bobtwinkles bobtwinkles referenced this pull request from a commit in bobtwinkles/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
5c2ceae
@aaccurso aaccurso referenced this pull request from a commit in aaccurso/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
997ab43
@arowla arowla referenced this pull request from a commit in arowla/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
6987ab2
@mkarklins mkarklins referenced this pull request from a commit in mkarklins/oh-my-zsh
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
0555b7c
@benjaoming benjaoming referenced this pull request from a commit in benjaoming/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
186ba11
@trynity trynity referenced this pull request from a commit in trynity/oh-my-zsh
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
3e634a6
@trynity trynity referenced this pull request from a commit in trynity/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
6dbd93a
@kenton kenton referenced this pull request from a commit in kenton/oh-my-zsh
@swanandp swanandp Support for opening tabs and windows in the same This fixed #1498 for…
… me on Mountain Lion
7072831
@kenton kenton referenced this pull request from a commit in kenton/oh-my-zsh
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
a1d9f09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 17, 2012
  1. @blueyed

    Use zsh's default for ':completion:*:hosts'

    blueyed authored
    The manual configuration of ':completion:*:hosts' causes some problems
    (e.g. issue #1337), and misses useful information (especially from
    ~/.ssh/known_hosts; issue #690 and issue #1009).
    
    The best option appears to be using zsh's default configuration for
    ':completion:*:hosts'.
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 13 deletions.
  1. +0 −13 lib/completion.zsh
View
13 lib/completion.zsh
@@ -31,19 +31,6 @@ zstyle ':completion:*:*:*:*:processes' command "ps -u `whoami` -o pid,user,comm
zstyle ':completion:*:cd:*' tag-order local-directories directory-stack path-directories
cdpath=(.)
-# use /etc/hosts and known_hosts for hostname completion
-[ -r /etc/ssh/ssh_known_hosts ] && _global_ssh_hosts=(${${${${(f)"$(</etc/ssh/ssh_known_hosts)"}:#[\|]*}%%\ *}%%,*}) || _global_ssh_hosts=()
-[ -r ~/.ssh/known_hosts ] && _ssh_hosts=(${${${${(f)"$(<$HOME/.ssh/known_hosts)"}:#[\|]*}%%\ *}%%,*}) || _ssh_hosts=()
-[ -r /etc/hosts ] && : ${(A)_etc_hosts:=${(s: :)${(ps:\t:)${${(f)~~"$(</etc/hosts)"}%%\#*}##[:blank:]#[^[:blank:]]#}}} || _etc_hosts=()
-hosts=(
- "$_global_ssh_hosts[@]"
- "$_ssh_hosts[@]"
- "$_etc_hosts[@]"
- "$HOST"
- localhost
-)
-zstyle ':completion:*:hosts' hosts $hosts
-
# Use caching so that commands like apt and dpkg complete are useable
zstyle ':completion::complete:*' use-cache 1
zstyle ':completion::complete:*' cache-path $ZSH/cache/
Something went wrong with that request. Please try again.