Update to latest per-directory-history #1635

Merged
merged 2 commits into from Apr 19, 2014

Conversation

Projects
None yet
4 participants
Contributor

jimhester commented Feb 28, 2013

See [https://github.com/jimhester/per-directory-history] for changes

Collaborator

mcornella commented Mar 2, 2014

👍 Fixes #2263

Collaborator

mcornella commented Mar 14, 2014

Hey I was having a look at this and saw that you separated the .plugin.zsh from the main file. What's wrong with putting it all in one file? It would make the PR cleaner

Contributor

jimhester commented Mar 14, 2014

I did it that way because standalone zsh scripts don't typically have
.plugin.zsh as their suffix. Since the script can be used standalone and
not only as a plugin I wanted to preserve the original name. I was
following the convention used by the (history substring search)[
https://github.com/robbyrussell/oh-my-zsh/tree/master/plugins/history-substring-search]
plugin.

On Fri, Mar 14, 2014 at 8:12 AM, Marc Cornellà notifications@github.comwrote:

Hey I was having a look at this and saw that you separated the .plugin.zshfrom the main file. What's wrong with putting it all in one file? It would
make the PR cleaner


Reply to this email directly or view it on GitHubhttps://github.com/robbyrussell/oh-my-zsh/pull/1635#issuecomment-37640831
.

Collaborator

mcornella commented Mar 24, 2014

cc @robbyrussell, this is cool to be merged. Fixes issue #2263 and even provides a cool README file.

Contributor

Kriechi commented Apr 5, 2014

Any ETA on merging this in?
I think it was reviewed long enough 😄

@jimhester maybe you could rebase & squash the commits.

Kriechi referenced this pull request Apr 5, 2014

Closed

directory-history plugin #2688

robbyrussell merged commit eafd5f3 into robbyrussell:master Apr 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment