Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Uncomment l alias #1773

Merged
merged 1 commit into from

7 participants

@essembeh

No description provided.

Sébastien M-B Uncomment l alias f77a545
@jcaudle jcaudle referenced this pull request from a commit
Sébastien M-B Comment l alias 18cb119
@rosstimson

Shame you can't upvote pull requests, it would help prioritise things in repos such as this where there are constantly a crazy amount of PRs and issues.

Over a month for such a tiny change which was committed by accident just shows that such 'busy' projects can become difficult to manage. I bet a whole load of PRs are just folk wanting their custom theme included - do we really need/want every other person's custom theme?

@essembeh

@rosstimson I totaly agree with you point of view.

The number of PR and delay between submission and acceptance may end if unwanted result such as my alias comment!

To me, forking a project is a way to customize it to my needs (adding your theme, etc...).

  • I originally forked it to add my theme and add ssh completion for host in ssh config.
  • Then I made PR #690 (late 2011) for the two (my theme could have been kept in my fork...)
  • After I commented the l alias (mid 2012) 18cb119, it was not part of the original PR #690

When the PR was accepted, There was conflicts (because of others PR merged after I submitted my PR #690 ) which I solved in my fork.
To solve them in upstream, my fork was merged and so was my unfortunate alias comment!

When I see the number of comments and work for this simple alias comment, I would like to know if there is a right way to fork a project to do both, contribute to upstream and customize without issue like my alias comment.
Maybe I should have kept my customizations in a custom branch...

On the question do we need/want others themes, I would say yes, it is interesting to discover tweaks such as prompt color change per ssh connection, git information ... I originally tried oh-my-zsh for its themes ;)

@zertrin

@robbyrussell any chance that this tiny fix will be merged in the foreseeable future?

@robbyrussell robbyrussell merged commit 4f8d6a8 into robbyrussell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 28, 2013
  1. Uncomment l alias

    Sébastien M-B authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/aliases.zsh
View
2  lib/aliases.zsh
@@ -17,7 +17,7 @@ alias history='fc -l 1'
# List direcory contents
alias lsa='ls -lah'
-#alias l='ls -la'
+alias l='ls -la'
alias ll='ls -l'
alias la='ls -lA'
alias sl=ls # often screw this up
Something went wrong with that request. Please try again.