gpg-agent plugin service check changed #2063

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@cdimartino

Running on OsX 10.8:

When using gpg-agent plugin, found numerous instances of gpg-agent running on my system, growing linearly with time. Found existing check for running services is calling a deprecated command.

gpg-agent -q has the same effect.

image

Chris DiMartino gpg-agent plugin service check changed
  - running on OsX 10.8
    - When using gpg-agent plugin, found numerous instances of gpg-agent
      running on my system, growing linearly with time.  Found existing
      check for running services is calling a deprecated command.
86059f3
Collaborator

Needs testers, but it appears to be correct. Could you also point to some relevant documentation regarding how both gpg-connect-agent and gpg-agent solutions work?

This change no longer appears necessary, as gpg-agent-connect properly returns a non-zero exit code if gpg-agent is not running. Feel free to close without merge, or go forward and merge at your discretion. Both methods appear to be valid for checking that gpg-agent is running.

Collaborator

Ok, I'm not sure that it's the final solution, but if you say that as is it already works, let's close this. Obviously in some version it didn't work, but it seems no one is complaining now...

There are other ways to check if it's running, I know prezto uses a different one and this guy here another more complex one, but I couldn't find the ultimate best practice.

Agree to close this 👍

@cdimartino cdimartino closed this Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment