Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Catimg plugin #2331

Merged
merged 4 commits into from Mar 8, 2014

Conversation

Projects
None yet
5 participants
Contributor

posva commented Dec 9, 2013

catimg allows to print pictures to the stdout using convert (ImageMagick)

drunk

Usage catimg [-h] [-w width] [-c char] img
By default char is "  " and w is the terminal width

posva added some commits Dec 9, 2013

catimg plugin
allow to print an image to the stdout using convert
catimg: fix exit without using source
supresses errors from convert whilen converting, as they
are usually just warnings

JoahG commented Dec 9, 2013

lol 👍

Contributor

christianschmidt commented Dec 11, 2013

+1

Contributor

posva commented Dec 11, 2013

lol 👍


+1

Thanks 😄

I forgot to say that I can change it into a single commit if it causes any kind of problem

At the time this test is executed by ZSH, my PATH is not yet completely set, hence it doesn't see the convert binary from ImageMagick. Which means each time a new shell is created, I get the warning about missing ImageMagick.

Ideally this check could be embedded in the function, and echo the warning at use time.

Owner

posva replied Feb 23, 2014

@bric3 You're totally right, I'll fix this. Thank You
I still don't know if the fact that there are 3-4 commits makes a difference

Contributor

bric3 commented Feb 23, 2014

+1 but the warning issue must be fixed.

Verification of convert inside the function
Depending on when the path is declared this solution would work in any case
Owner

robbyrussell commented Mar 8, 2014

Can we get a random image feature? ;-)

robbyrussell added a commit that referenced this pull request Mar 8, 2014

@robbyrussell robbyrussell merged commit a811ab0 into robbyrussell:master Mar 8, 2014

Contributor

posva commented Mar 8, 2014

@robbyrussell haha, I guess that would be way too useless to be a real plugin :P

@posva posva deleted the posva:catimg branch Mar 8, 2014

w31 pushed a commit to w31/oh-my-zsh that referenced this pull request Apr 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment