New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme agnoster: update characters to match latest powerline fonts #2479

Merged
merged 3 commits into from Mar 8, 2014

Conversation

Projects
None yet
9 participants
@mrbfrank
Contributor

mrbfrank commented Jan 30, 2014

Clearing up some confusion in issue #1906. Powerline has changed the Unicode characters for font patching, see their change here: powerline/powerline@53fbfe1 which is described here: powerline/powerline#4. This pull request is to comply with those changes in agnoster.zsh-theme, which relies on a Powerline patched font. Users should patch their font with the latest version of Powerline or download the newest pre-patched fonts here https://github.com/Lokaltog/powerline-fonts.
screen shot 2014-01-29 at 6 35 39 pm

mrbfrank added some commits Jan 29, 2014

updated url to latest powerline-patched fonts
clearing up some confusion in issue#1906
theme agnoster: remove trailing space
re-implemented expired pull request #1759
@fitztrev

This comment has been minimized.

fitztrev commented Jan 30, 2014

+1

4 similar comments
@SimenB

This comment has been minimized.

Contributor

SimenB commented Feb 13, 2014

+1

@joelcdoyle

This comment has been minimized.

joelcdoyle commented Feb 17, 2014

+1

@m0nkmaster

This comment has been minimized.

m0nkmaster commented Feb 27, 2014

👍

@mcornella

This comment has been minimized.

Collaborator

mcornella commented Feb 28, 2014

👍

@pierreozoux

This comment has been minimized.

pierreozoux commented Mar 5, 2014

Ouh Yeah! 👍

robbyrussell added a commit that referenced this pull request Mar 8, 2014

Merge pull request #2479 from mrbfrank/theme-agnoster
theme agnoster: update characters to match latest powerline fonts

@robbyrussell robbyrussell merged commit e744bf2 into robbyrussell:master Mar 8, 2014

@mrbfrank

This comment has been minimized.

Contributor

mrbfrank commented Mar 8, 2014

Thanks everyone ✌️

w31 pushed a commit to w31/oh-my-zsh that referenced this pull request Apr 30, 2014

Merge pull request robbyrussell#2479 from mrbfrank/theme-agnoster
theme agnoster: update characters to match latest powerline fonts
@paulodelgado

This comment has been minimized.

paulodelgado commented on 7daaa18 Aug 26, 2014

I don't think this is the right character we're looking for, or is it?

j0fiunuj

This comment has been minimized.

Contributor

mrbfrank replied Sep 17, 2014

Hi Paulo, it is the correct character for the latest powerline font used by the agnoster theme. With a new powerline font configured in your terminal, that character should render as the branch symbol. See my pull request for a screenshot and detailed explanation: #2479

Important to note that Powerline recently changed the Unicode characters they used to patch fonts, which precipitated this change to the theme. Make sure you have a newer powerline font installed.

Glad to help if you have further questions, thanks!

@mrbfrank mrbfrank deleted the mrbfrank:theme-agnoster branch Apr 2, 2015

@mrbfrank mrbfrank restored the mrbfrank:theme-agnoster branch Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment