Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for colored ls on openbsd. (retry of #2225) #2751

Merged
merged 1 commit into from Sep 19, 2015
Merged

add check for colored ls on openbsd. (retry of #2225) #2751

merged 1 commit into from Sep 19, 2015

Conversation

drm00
Copy link

@drm00 drm00 commented Apr 25, 2014

Retry of PR #2225, with help from @ncanceill. Will close the old PR now.

@mcornella
Copy link
Member

@drm00 you could add the comments in the description of the PR, makes it easier to review.

This basically runs both gls and colorls to see if they are available and working, then aliases them to ls. Since colorls is aliased to ls first, if both commands are available, colorls will be aliased last overriding the gls alias. That is the intended behaviour since colorls needs to be installed separately and on purpose, while gls comes bundled within the coreutils package and may not be specifically wanted.

👍 from me

@drm00
Copy link
Author

drm00 commented Aug 7, 2014

You're right, i should have added a description. Thanks for pointing out, i'll do so next time :)

@mcornella
Copy link
Member

Sorry for the long wait! 😅

/cc @robbyrussell

robbyrussell added a commit that referenced this pull request Sep 19, 2015
add check for colored ls on openbsd. (retry of #2225)
@robbyrussell robbyrussell merged commit 5e45c16 into ohmyzsh:master Sep 19, 2015
@drm00 drm00 deleted the fix-openbsd-colorls branch September 19, 2015 16:04
nunogt pushed a commit to nunogt/oh-my-zsh that referenced this pull request Jan 25, 2016
add check for colored ls on openbsd. (retry of ohmyzsh#2225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants