Rollback of Pull #366 #375

Merged
merged 2 commits into from Jun 1, 2011

Conversation

Projects
None yet
4 participants
Contributor

betawaffle commented May 30, 2011

Rollback of Pull #366
sorin-ionescu had some good points.
plugins/rvm/rvm.plugin.zsh
-autoload -U compinit
-compinit -i
+# What does this really do?
+# fpath=($ZSH/plugins/rvm $fpath)
@vguerci

vguerci May 30, 2011

Contributor

it adds rvm plugin to $fpath which is used by compinit to load completions
Now useless and redundant since all plugins are already added to $fpath in main oh-my-zsh.sh script :
for plugin ($plugins) fpath=($ZSH/plugins/$plugin $fpath)

@betawaffle

betawaffle May 30, 2011

Contributor

Thanks.

@sorin-ionescu

sorin-ionescu May 30, 2011

Contributor

You don't need that line. I have forgotten to mention it. I'm sorry for the confusion.

@vguerci

vguerci May 30, 2011

Contributor

@sorin-ionescu don't be sorry about this, and btw, thanks for the extensive review of previous pull / related commits ;)

# Open the node api for your current version to the optional section.
# TODO: Make the section part easier to use.
-function node-api {
+function node-docs {
open "http://nodejs.org/docs/$(node --version)/api/all.html#$1"
@sorin-ionescu

sorin-ionescu May 30, 2011

Contributor

xdg-open is available for Gnome, KDE, et al. You need to check if it's a Mac or everything else and execute the proper open command.

@betawaffle

betawaffle May 30, 2011

Contributor

How do you recommend I check for darwin, or osx if that would be more accurate?

@sorin-ionescu

sorin-ionescu May 30, 2011

Contributor

You can use uname, which says, 'Darwin'. Maybe, we should have a function in /lib/functions.zsh that deals with all the different open commands.

@sorin-ionescu

sorin-ionescu May 30, 2011

Contributor

Alternatively, Instead of a function, one could set an alias in /lib/aliases.zsh like so.

if [[ $(uname) != 'Darwin' && -x "${+commands[xdg-open]}" ]]; then
  alias open='xdg-open'
fi

There are a bunch of open commands on different systems. I ask that people list them for us to implement a proper wrapper function or aliases.

robbyrussell added a commit that referenced this pull request Jun 1, 2011

@robbyrussell robbyrussell merged commit 643a4e7 into robbyrussell:master Jun 1, 2011

sorin-ionescu referenced this pull request in sorin-ionescu/prezto Jan 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment