Display red dots during completion process (disabled by default) #492

Merged
merged 2 commits into from Aug 11, 2011

Conversation

Projects
None yet
5 participants
@hwti
Contributor

hwti commented Jul 24, 2011

It allows to see completion is in progress, usually preventing the bad reflex of hitting tab key again when completion is slow.

@eatnumber1

This comment has been minimized.

Show comment Hide comment
@eatnumber1

eatnumber1 Jul 27, 2011

Contributor

Doesn't work for echo **/*<TAB>

Contributor

eatnumber1 commented Jul 27, 2011

Doesn't work for echo **/*<TAB>

@hwti

This comment has been minimized.

Show comment Hide comment
@hwti

hwti Jul 27, 2011

Contributor

It's strange, It works for me.

Is it systematic (in all directories) ?
Do other completions work ?

Contributor

hwti commented Jul 27, 2011

It's strange, It works for me.

Is it systematic (in all directories) ?
Do other completions work ?

@robbyrussell

This comment has been minimized.

Show comment Hide comment
@robbyrussell

robbyrussell Jul 28, 2011

Owner

This is neat... if this works... I'd prefer this to be, by default, enabled and you could disable it via the config. Want to make that change? I'm a big fan of improving the user interaction of the shell itself as best we can.

Owner

robbyrussell commented Jul 28, 2011

This is neat... if this works... I'd prefer this to be, by default, enabled and you could disable it via the config. Want to make that change? I'm a big fan of improving the user interaction of the shell itself as best we can.

@eatnumber1

This comment has been minimized.

Show comment Hide comment
@eatnumber1

eatnumber1 Jul 28, 2011

Contributor

My mistake, I was just misusing it. It works for the case I mentioned above.

Contributor

eatnumber1 commented Jul 28, 2011

My mistake, I was just misusing it. It works for the case I mentioned above.

@hwti

This comment has been minimized.

Show comment Hide comment
@hwti

hwti Jul 28, 2011

Contributor

Now enabled by default as requested

Contributor

hwti commented Jul 28, 2011

Now enabled by default as requested

robbyrussell added a commit that referenced this pull request Aug 11, 2011

Merge pull request #492 from hwti/red-dots-completion
Display red dots during completion process (disabled by default)

@robbyrussell robbyrussell merged commit be2ab22 into robbyrussell:master Aug 11, 2011

@robbyrussell

This comment has been minimized.

Show comment Hide comment
@robbyrussell

robbyrussell Aug 11, 2011

Owner

I love this! thanks so much. :-)

Owner

robbyrussell commented Aug 11, 2011

I love this! thanks so much. :-)

@sorin-ionescu

This comment has been minimized.

Show comment Hide comment
@sorin-ionescu

sorin-ionescu Aug 14, 2011

Contributor

This conflicts with rationalize-dot, which is far more useful. It translates .... into ../.. automatically saving the user from typing slash. Perhaps a unicode character that looks like a dot but isn't is better suited.

Contributor

sorin-ionescu commented Aug 14, 2011

This conflicts with rationalize-dot, which is far more useful. It translates .... into ../.. automatically saving the user from typing slash. Perhaps a unicode character that looks like a dot but isn't is better suited.

@hwti

This comment has been minimized.

Show comment Hide comment
@hwti

hwti Aug 14, 2011

Contributor

Can you give me an example ?
I don't see any conflict.

Contributor

hwti commented Aug 14, 2011

Can you give me an example ?
I don't see any conflict.

@sorin-ionescu

This comment has been minimized.

Show comment Hide comment
@sorin-ionescu

sorin-ionescu Aug 15, 2011

Contributor

The function is not in oh-my-zsh, but it's a popular.

# Convert .... to ../.. automatically.
function rationalize-dot() {
  if [[ $LBUFFER = *.. ]]; then
    LBUFFER+=/..
  else
    LBUFFER+=.
  fi
}
zle -N rationalize-dot

# Expand .... to ../..
bindkey "." rationalize-dot

# Do not expand .... to ../..  during incremental search.
bindkey -M isearch . self-insert 2>/dev/null
Contributor

sorin-ionescu commented Aug 15, 2011

The function is not in oh-my-zsh, but it's a popular.

# Convert .... to ../.. automatically.
function rationalize-dot() {
  if [[ $LBUFFER = *.. ]]; then
    LBUFFER+=/..
  else
    LBUFFER+=.
  fi
}
zle -N rationalize-dot

# Expand .... to ../..
bindkey "." rationalize-dot

# Do not expand .... to ../..  during incremental search.
bindkey -M isearch . self-insert 2>/dev/null
@hwti

This comment has been minimized.

Show comment Hide comment
@hwti

hwti Aug 15, 2011

Contributor

What's the problem ?
I can't find any interaction between this and red-dots-completion.

Contributor

hwti commented Aug 15, 2011

What's the problem ?
I can't find any interaction between this and red-dots-completion.

@sorin-ionescu

This comment has been minimized.

Show comment Hide comment
@sorin-ionescu

sorin-ionescu Aug 15, 2011

Contributor

Use ... dots, and it should be fine.

Contributor

sorin-ionescu commented Aug 15, 2011

Use ... dots, and it should be fine.

@hwti

This comment has been minimized.

Show comment Hide comment
@hwti

hwti Aug 15, 2011

Contributor

Middle dot (U+00B7) can be used too.

But I don't understand, why do you need this change ? I don't see any problem with the dots (they are not replaced by ../.., or anything else).

Contributor

hwti commented Aug 15, 2011

Middle dot (U+00B7) can be used too.

But I don't understand, why do you need this change ? I don't see any problem with the dots (they are not replaced by ../.., or anything else).

@sorin-ionescu

This comment has been minimized.

Show comment Hide comment
@sorin-ionescu

sorin-ionescu Aug 15, 2011

Contributor

I experienced just that, the dots being replaced with ../../../... It depends on the way the key bindings are set up.

Contributor

sorin-ionescu commented Aug 15, 2011

I experienced just that, the dots being replaced with ../../../... It depends on the way the key bindings are set up.

@robbyrussell

This comment has been minimized.

Show comment Hide comment
@robbyrussell

robbyrussell Aug 19, 2011

Owner

@hwti hey there... after playing with this, I'm going to exercise my right to change my mind. ;-)

I think that we should switch this to be off by default... and provide a way for people to enable it. Can you send in another version with your original approach and any other thoughts you've had since we pulled this in?

Thanks so much!

Cheers,
Robby

Owner

robbyrussell commented Aug 19, 2011

@hwti hey there... after playing with this, I'm going to exercise my right to change my mind. ;-)

I think that we should switch this to be off by default... and provide a way for people to enable it. Can you send in another version with your original approach and any other thoughts you've had since we pulled this in?

Thanks so much!

Cheers,
Robby

@olivierverdier

This comment has been minimized.

Show comment Hide comment
@olivierverdier

olivierverdier Aug 23, 2011

Perhaps the function expand-or-complete-with-dots could at least be available by default? This could also be a stand alone plugin?

Anyway, I love those red dots. (see also #562)

Perhaps the function expand-or-complete-with-dots could at least be available by default? This could also be a stand alone plugin?

Anyway, I love those red dots. (see also #562)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment