Update bira theme #4954

Merged
merged 2 commits into from Oct 15, 2016

Projects

None yet

2 participants

@jocelynthode
Contributor

I saw the latest update that changed the color of the name when you're in root. I thought it would be neat to have the symbol also change from '$' to '#' as a root prompt is always represented with '#'.

I also put the return code in bold as I think it is not visible enough when not bold.

@mcornella mcornella added the theme label Mar 30, 2016
@mcornella mcornella commented on the diff Mar 30, 2016
themes/bira.zsh-theme
@@ -20,8 +22,9 @@ fi
local git_branch='$(git_prompt_info)%{$reset_color%}'
PROMPT="╭─${user_host} ${current_dir} ${rvm_ruby} ${git_branch}
-╰─%B$%b "
-RPS1="${return_code}"
+╰─%B${user_symbol}%b "
@mcornella
mcornella Mar 30, 2016 Collaborator

It's shorter using %(!.#.$) (see prompt expansion).

The previous user_host stuff could be similarly abbreviated with a %(!.$fg[red].$fg[green]), but let's leave that for another time.

@jocelynthode
Contributor

@mcornella Any ETA on merging this change ?

@mcornella mcornella merged commit cff228e into robbyrussell:master Oct 15, 2016
@freecastle freecastle added a commit to freecastle/oh-my-zsh that referenced this pull request Oct 17, 2016
@freecastle freecastle Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
* 'master' of https://github.com/robbyrussell/oh-my-zsh: (33 commits)
  Update bira theme (#4954)
  Display suvash prompt w/o Ruby; refactor code
  readme change OS X to macOS
  Fix ls coloring in MacOS if gls is not installed
  Fix ls colouring for Darwin. (#5516)
  Use $+commands to check the existence of a command in clipboard.zsh. (#5519)
  Use OSTYPE instead of uname whenever possible for better speed. (#5496)
  Take advantage of LS_COLORS for the color of completion if GNU ls is used. (#5510)
  remove duplicate alias (#5508)
  Add m4a format in the common aliases plugin (#5502)
  Add non 0 exit code for missing jump targets (#5500)
  Fix compdef commands in git plugin
  Update per-directory-history plugin to latest version (#5493)
  Fix formatting and usage section
  fix comment
  README for globalias
  specify globalias modes
  Fix style of theme-and-appearance.zsh
  Only set default LS_COLORS if not set before
  Use `$commands[]` to check for command existence
  ...
d9f9b16
@foobacca foobacca added a commit to foobacca/oh-my-zsh that referenced this pull request Oct 18, 2016
@foobacca foobacca Merge remote-tracking branch 'origin/master' into personal
* origin/master:
  Change from OSX to macOS in README (#5545)
  Update README with grammar corrections (#5503)
  Fix regex for optional http(s), and variable reference inside osascript.
  Update bira theme (#4954)
  Display suvash prompt w/o Ruby; refactor code
  readme change OS X to macOS
37eae18
@pranith pranith added a commit to pranith/oh-my-zsh that referenced this pull request Oct 19, 2016
@jocelynthode @pranith jocelynthode + pranith Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
98f949d
@akharlamov akharlamov added a commit to akharlamov/oh-my-zsh that referenced this pull request Oct 23, 2016
@akharlamov akharlamov Merge remote-tracking branch 'upstream/master'
* upstream/master: (86 commits)
  Change from OSX to macOS in README (#5545)
  Update README with grammar corrections (#5503)
  Fix regex for optional http(s), and variable reference inside osascript.
  Update bira theme (#4954)
  Display suvash prompt w/o Ruby; refactor code
  readme change OS X to macOS
  Fix ls coloring in MacOS if gls is not installed
  Fix ls colouring for Darwin. (#5516)
  Use $+commands to check the existence of a command in clipboard.zsh. (#5519)
  Use OSTYPE instead of uname whenever possible for better speed. (#5496)
  Take advantage of LS_COLORS for the color of completion if GNU ls is used. (#5510)
  remove duplicate alias (#5508)
  Add m4a format in the common aliases plugin (#5502)
  Add non 0 exit code for missing jump targets (#5500)
  Fix compdef commands in git plugin
  Update per-directory-history plugin to latest version (#5493)
  Fix formatting and usage section
  fix comment
  README for globalias
  specify globalias modes
  ...
50f4f3d
@elcepi elcepi added a commit to elcepi/oh-my-zsh that referenced this pull request Oct 24, 2016
@jocelynthode @elcepi jocelynthode + elcepi Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
5f61149
@DennisDenuto DennisDenuto added a commit to DennisDenuto/oh-my-zsh that referenced this pull request Oct 29, 2016
@jocelynthode @DennisDenuto jocelynthode + DennisDenuto Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
cdac373
@jplandrain jplandrain added a commit to jplandrain/oh-my-zsh that referenced this pull request Oct 31, 2016
@jocelynthode @jplandrain jocelynthode + jplandrain Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
da046ff
@warmwind warmwind added a commit to warmwind/oh-my-zsh that referenced this pull request Oct 31, 2016
@jocelynthode @warmwind jocelynthode + warmwind Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
00331f3
@aegixx aegixx pushed a commit to aegixx/oh-my-zsh that referenced this pull request Nov 22, 2016
@jocelynthode jocelynthode + Bryan Stone Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
6a0ff78
@aaronbieber aaronbieber added a commit to aaronbieber/oh-my-zsh that referenced this pull request Dec 15, 2016
@jocelynthode @aaronbieber jocelynthode + aaronbieber Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
704d3fc
@avleen avleen added a commit to avleen/oh-my-zsh that referenced this pull request Dec 23, 2016
@jocelynthode @avleen jocelynthode + avleen Update bira theme (#4954)
* Add '#' instead of '$' when in root
* Make return code bold
a1052a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment