Shell variables such as PAGER should not be set #564

Closed
wants to merge 2 commits into from

3 participants

@olivierverdier

the problem is that they overrride the variable definitions in .zshenv

@olivierverdier olivierverdier variables such as PAGER should not be set
the problem is that they overrride the variable definitions in .zshenv
65f3dab
@gwjo

I created a pull request (#291) ages ago that fixes this in a slightly different way, it only sets the environment variables if they aren't already set.

I also did if for GREP_OPTIONS and GREP_COLOR

@olivierverdier

ah, thanks, that's indeed the right way to go... should I close my pull request then?

@gwjo
@olivierverdier

ok, I take a slightly more extreme position than yours, then... :-P I think it's better if oh-my-zsh keeps it to zsh settings..

it's now up to @robbyrussell to choose...

(Another solution would be to make a grep plugin. same for pager.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment