Change af-magic theme's branch color #5730

Merged
merged 4 commits into from Jan 9, 2017

Projects

None yet

4 participants

@haandol
Contributor
haandol commented Dec 28, 2016 edited

I love af-magic theme because of it's simplicity!
but its coloring is too simple to recognize which branch is now on.
so I changed branch color from 075, almost same color as path(prefix) color, to 078(same tone but green color)

And also I removed 'branch:' description for displaying branch information.
I think it is conceptually duplicated because the part is only for the branch status.

From
2016-12-28 11 51 26
To
2017-01-09 12 40 20

@mcornella
Collaborator

LGTM but please change the color of the first parenthesis to be the same as the last.

@haandol
Contributor
haandol commented Jan 5, 2017 edited

@mcornella oh thanks, I fixed it at 795d9b1 already. I gonna update my screenshot

@mcornella
Collaborator

Oh, I meant the same kind of blue. Right now they're all green as the branch name right?

@haandol
Contributor
haandol commented Jan 6, 2017 edited

Understood. 👍
That looks better, I think.

themes/af-magic.zsh-theme
ZSH_THEME_GIT_PROMPT_CLEAN=""
ZSH_THEME_GIT_PROMPT_DIRTY="$my_orange*%{$reset_color%}"
-ZSH_THEME_GIT_PROMPT_SUFFIX="$FG[075])%{$reset_color%}"
+ZSH_THEME_GIT_PROMPT_SUFFIX="$FG[078])%{$reset_color%}"
@RyanBrushett
RyanBrushett Jan 6, 2017 Contributor

The parenthesis before 'branch' is a different colour than the SUFFIX parenthesis.

The following example makes sure they're both the same colour:
ZSH_THEME_GIT_PROMPT_SUFFIX=")$FG[078]%{$reset_color%}"

@mcornella mcornella merged commit 0b4bba4 into robbyrussell:master Jan 9, 2017
@mcornella
Collaborator

Thanks everybody!

@muesli muesli added a commit to muesli/oh-my-zsh that referenced this pull request Jan 10, 2017
@haandol @muesli haandol + muesli Change af-magic theme's branch color (#5730) b954fc3
@Murderlon Murderlon added a commit to Murderlon/oh-my-zsh that referenced this pull request Jan 11, 2017
@Murderlon Murderlon Merge branch 'master' of https://github.com/Murderlon/oh-my-zsh
* 'master' of https://github.com/Murderlon/oh-my-zsh: (52 commits)
  Change af-magic theme's branch color (#5730)
  Adding new path to look for activate.sh (#5654)
  Improved gradle options (arguments) completion (#5743)
  chore: update license years (#5737)
  Improve UX for Spotify quit command in osx plugin (#5726)
  'themes/trapd00r.zsh-theme: Solve typos'
  'themes/steeef.zsh-theme: Solve typos'
  'themes/pure.zsh-theme: Solve typos'
  'themes/half-life.zsh-theme: Solve typos'
  'plugins/z/z.1: Solve typos'
  'plugins/z/README: Solve typos'
  'plugins/ubuntu/ubuntu.plugin.zsh: Solve typos'
  'plugins/ubuntu/readme.md: Solve typos'
  'plugins/terraform/_terraform: Solve typos'
  'plugins/suse/suse.plugin.zsh: Solve typos'
  'plugins/scala/_scala: Solve typos'
  'plugins/history-substring-search/history-substring-search.zsh: Solve typos'
  'plugins/gnu-utils/gnu-utils.plugin.zsh: Solve typos'
  'plugins/droplr/README.md: Solve typos'
  'lib/functions.zsh: Solve typos'
  ...
59f4389
@hjpotter92
Contributor

Would help if you also update the image in wiki

@haandol
Contributor
haandol commented Jan 13, 2017

2017-01-13 10 31 45

@blwalker blwalker added a commit to blwalker/oh-my-zsh that referenced this pull request Jan 16, 2017
@haandol @blwalker haandol + blwalker Change af-magic theme's branch color (#5730) 0057878
@foobacca foobacca pushed a commit to foobacca/oh-my-zsh that referenced this pull request Jan 17, 2017
Hamish Downer Merge remote-tracking branch 'origin/master' into personal
* origin/master:
  Add goodreads search provider (#5778)
  Change af-magic theme's branch color (#5730)
  Adding new path to look for activate.sh (#5654)
  Improved gradle options (arguments) completion (#5743)
ef6afe6
@freecastle freecastle added a commit to freecastle/oh-my-zsh that referenced this pull request Jan 17, 2017
@freecastle freecastle Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
* 'master' of https://github.com/robbyrussell/oh-my-zsh:
  Add goodreads search provider (#5778)
  Change af-magic theme's branch color (#5730)
  Adding new path to look for activate.sh (#5654)
  Improved gradle options (arguments) completion (#5743)
c28f3b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment