Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer virtualenvwrapper_lazy #6842

Merged
merged 1 commit into from May 26, 2018

Conversation

Projects
None yet
3 participants
@lbolla
Copy link
Contributor

commented May 20, 2018

This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix #6839

Fix 6839 Prefer virtualenvwrapper_lazy
This gives much faster start up times and only loads virtualenvwrapper
when needed.

@mcornella mcornella changed the title Fix 6839 Prefer virtualenvwrapper_lazy Prefer virtualenvwrapper_lazy May 26, 2018

@mcornella

This comment has been minimized.

Copy link
Collaborator

commented May 26, 2018

Can you try to reproduce #2355 (comment)? I think the bug should still be there, that's why we removed support for it in #2615.

@lbolla

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2018

#2355 (comment) seems like an issue with MacOS's iTerm: I don't have a Mac to test.
Can't we just enable lazy virtualenvwrapper on Linux and Windows, if it's broken on Mac?

@mcornella

This comment has been minimized.

Copy link
Collaborator

commented May 26, 2018

I'm not sure that's really a Mac, the bug report to zsh's mailing list doesn't mention it, though it is true that many in the issue thread do mention Mac and iTerm.

Can you just try if completing a virtualenv name using workon <virtualenv><TAB> closes the tab or prints an error like the one in the issue? If not, we can just pull this and reenable virtualenvwrapper_lazy.

@lbolla

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2018

workon <virtualenv><TAB> works fine for me, using urxvt and xterm on Linux and zsh 5.5.1.

@mcornella mcornella merged commit 90a5bd0 into robbyrussell:master May 26, 2018

@mcornella

This comment has been minimized.

Copy link
Collaborator

commented May 26, 2018

Thanks for looking into it!

@clokep

This comment has been minimized.

Copy link

commented May 29, 2018

This seems to have broken automatically activating virtualenvs when moving to directories in git projects. I was able to revert 90a5bd0 and it started working again.

sciabarracom pushed a commit to sciabarracom/oh-my-zsh that referenced this pull request Jun 1, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839
@lbolla

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2018

@clokep I guess the "auto venv activation plugin" should run "workon" upon init, which will trigger the lazy loading of virtualenvwrapper.

@mcornella

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2018

I pushed an update to fix the logic. Run upgrade_oh_my_zsh to update.

@clokep

This comment has been minimized.

Copy link

commented Jun 6, 2018

@mcornella Thank you! I confirmed it is working for me now!

fdelacruz added a commit to fdelacruz/oh-my-zsh that referenced this pull request Jun 9, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839

aunsira added a commit to aunsira/oh-my-zsh that referenced this pull request Jun 13, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839

gsemet added a commit to gsemet/oh-my-zsh that referenced this pull request Jun 15, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839

bjornreppen added a commit to bjornreppen/oh-my-zsh that referenced this pull request Aug 11, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839

seth-cohen pushed a commit to seth-cohen/oh-my-zsh that referenced this pull request Oct 29, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839

jmartindf added a commit to jmartindf/oh-my-zsh that referenced this pull request Nov 10, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839

sagischwarz pushed a commit to sagischwarz/oh-my-zsh that referenced this pull request Nov 19, 2018

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839

pawsen added a commit to pawsen/oh-my-zsh that referenced this pull request Jan 19, 2019

Prefer virtualenvwrapper_lazy (robbyrussell#6842)
This gives much faster start up times and only loads virtualenvwrapper
when needed.

Fix robbyrussell#6839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.