Adding ~/.ssh/config parsing for host list and theme. #690

Merged
merged 13 commits into from Apr 24, 2013

Projects

None yet
@essembeh
Contributor
essembeh commented Nov 4, 2011

Just a commit to add Hosts from ssh/config file in host completion for ssh.
I found the tip on a wiki (see commit message for url).

I also made my theme :)

Sébastien M-B added some commits Nov 4, 2011
Sébastien M-B Adding custom theme 914e1b5
Sébastien M-B Update completion for SSH
Add all hosts found in ~/.ssh/config.
Tip found on: http://www.nerux.org/wiki/OpenSSH#coupler_avec_zsh_completion
c4434d2
Sébastien M-B Update theme
Use different colors in case of root or ssh connection for prompt.
8e6ce53
Sébastien M-B Merge remote branch 'upstream/master' 9969fca
Sébastien M-B Merge remote branch 'upstream/master' 3726611
Sébastien M-B and others added some commits Apr 12, 2012
@blueyed blueyed added a commit to blueyed/oh-my-zsh that referenced this pull request Dec 17, 2012
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.
ef002a8
@blueyed blueyed added a commit to blueyed/oh-my-zsh that referenced this pull request Jan 10, 2013
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

Conflicts:

	lib/completion.zsh
cabe82d
Sébastien M-B added some commits Feb 8, 2013
mcoquet commented Apr 10, 2013

Is this in line to make it into the main branch? I'd love to have this feature working

@robbyrussell robbyrussell merged commit b6ea876 into robbyrussell:master Apr 24, 2013
@janernsting

I guess, this was not supposed to be part of your pull request @essembeh

Contributor

You are right. I don't know what I did wrong and how this commit is part of the pull request, sorry.

No problem ;) Just wanted to make sure, it did not end up there on purpose.

@mbauhardt
Contributor

i miss the l alias

please but it back

What was the reason behind commenting this out. I can put it back in my local instance, but I would like to know if this was breaking anything or something else that I need to watch out for.

@sbansal: @essembeh confirmed that the commenting of alias l happened on accident.

please put it back 👍

Just adding a voice. It'd be great to have l back.

Guys, there is a pull request submitted for this already #1802. Hopefully it would be accepted soon. Patience my friends :)

Actually, @sbansal, #1773 was submitted directly by @essembeh to undo this. I've closed #1802 in favor of the original pull request.

Contributor

Yes you can uncomment it in your local instance.
I don't know how this commit was par of my pull request, I just submitted #1773 to put the alias back.

@essembeh essembeh referenced this pull request May 28, 2013
Merged

Uncomment l alias #1773

@jolan78

This breaks local users completion :
cd ~ro used to complete as cd ~root/
is this expected ? i was disapointed by this change.

Contributor

I found the tip on http://www.nerux.org/wiki/OpenSSH#coupler_avec_zsh_completion
As a totally beginner with zsh, I just copied the lines.
I don't know why they turned off the users completion.
Removing line 46 does not seem to impact the ssh host completion, it could be removed.

opened an issue : #1857

@blueyed blueyed added a commit to blueyed/oh-my-zsh that referenced this pull request Mar 13, 2014
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
71d9420
@apoh apoh added a commit to apoh/oh-my-zsh that referenced this pull request Apr 8, 2014
@blueyed @apoh blueyed + apoh Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
0c73c41
@neiljdo neiljdo added a commit to neiljdo/oh-my-zsh that referenced this pull request Apr 11, 2014
@blueyed @neiljdo blueyed + neiljdo Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
113c231
@w31 w31 pushed a commit to w31/oh-my-zsh that referenced this pull request Apr 30, 2014
@blueyed blueyed Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
6eb3511
@bobtwinkles bobtwinkles added a commit to bobtwinkles/oh-my-zsh that referenced this pull request May 6, 2014
@blueyed @bobtwinkles blueyed + bobtwinkles Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
5c2ceae
@aaccurso aaccurso pushed a commit to aaccurso/oh-my-zsh that referenced this pull request May 17, 2014
@blueyed blueyed + Alan Accurso Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
997ab43
@arowla arowla added a commit to arowla/oh-my-zsh that referenced this pull request May 28, 2014
@blueyed @arowla blueyed + arowla Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
6987ab2
@benjaoming benjaoming added a commit to benjaoming/oh-my-zsh that referenced this pull request Nov 28, 2014
@blueyed @benjaoming blueyed + benjaoming Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
186ba11
@kenton kenton added a commit to kenton/oh-my-zsh that referenced this pull request Jan 9, 2015
@blueyed @kenton blueyed + kenton Use zsh's default for ':completion:*:hosts'
The manual configuration of ':completion:*:hosts' causes some problems
(e.g. issue #1337), and misses useful information (especially from
~/.ssh/known_hosts; issue #690 and issue #1009).

The best option appears to be using zsh's default configuration for
':completion:*:hosts'.

While rebasing this for a new pull request (#1498 got closed by accident
and then requests to re-open it got ignored), it also drops the `users
off` setting: completion of user names can be useful, and the commit
adding it (c4434d2) does not state why.
a1d9f09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment