Removed calls to compinit in the extract and the bundler plugins. #830

Merged
merged 2 commits into from Jan 18, 2012

Projects

None yet

4 participants

@dbye
dbye commented Jan 13, 2012

compinit should only be called once, after all modules, libs, etc are imported.

This change yields a much improved startup time, going from a life-sapping 3 seconds average before, to a much snappier 0.2 seconds average.

Daniel Bye Removed calls to compinit in the extract and the bundler plugins. com…
…pinit should only be called once, after all modules, libs, etc are imported.
c04b4ab
@gwjo
Contributor
gwjo commented Jan 13, 2012

The also don't need to update the fpath as it is already done before the plugins are sourced.

@netmute
netmute commented Jan 15, 2012

This has been bugging me for ages. Please merge as soon as possible :)

Daniel Bye Removed the assignments to fpath as well, since that's all handled in…
… the .oh-my-zsh/oh-my-zsh.sh boot script.
b73f95a
@dbye
dbye commented Jan 16, 2012

@gwjo - good catch. I've removed those two assignments also. Possibly for broader discussion elsewhere - should we be adding to fpath plugin directories we don't use? The current strategy seems to cycle through the whole contents of the plugins directory.

@robbyrussell robbyrussell merged commit 7cb5a5d into robbyrussell:master Jan 18, 2012
@robbyrussell
Owner

Thanks for the submission!

@robbyrussell robbyrussell merged commit b73f95a into robbyrussell:master Jan 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment