New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX? #2

Closed
CardcaptorStacey opened this Issue Sep 26, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@CardcaptorStacey
Copy link

CardcaptorStacey commented Sep 26, 2015

Can't seem to create any bookmarks on Mac!

@robcaa

This comment has been minimized.

Copy link
Owner

robcaa commented Sep 27, 2015

I don't have Mac .So I could not test. But it should work.

The keybinding API says:
"NOTE: If platform is not specified, Ctrl will be replaced by Cmd for "mac" platform"

You try CMD+SHIFT+number and nothing?
Maybe the bookmarks work, just not shown the number.

If it does not work absolutely. Can you see the brackets console (F12) and place a bookmark and watch in console if any error shown.

@CardcaptorStacey

This comment has been minimized.

Copy link
Author

CardcaptorStacey commented Sep 27, 2015

Thanks for getting back to me

Only CMD+SHIFT+2 seems to work. I think they other buttons are used for system and Brackets. Looks like CMD+SHIFT+1 is used as a shortcut to expand all in the Bracket view menu...

@robcaa

This comment has been minimized.

Copy link
Owner

robcaa commented Sep 27, 2015

What do you think. Which combination of keys would be good for Mac?
If you help me I add that shortcuts to the extension.

@CardcaptorStacey

This comment has been minimized.

Copy link
Author

CardcaptorStacey commented Sep 27, 2015

CMD+ALT+#?

@robcaa

This comment has been minimized.

Copy link
Owner

robcaa commented Sep 29, 2015

Ok. When I have a little time, I will make this hotkeys for MAC and you can test it.

@robcaa

This comment has been minimized.

Copy link
Owner

robcaa commented Sep 29, 2015

OK. I added MAC hotkeys:

  • Cmd-ALT-Delete delete all bookmarks
  • Cmd-ALT-# place bookmark
  • Cmd-# jump to bookmark

Can you test these hotkeys? Just replace main.js and restart brackets.

@CardcaptorStacey

This comment has been minimized.

Copy link
Author

CardcaptorStacey commented Oct 1, 2015

Damn, doesn't seem to work :(

CMD-1 (to jump to bookmark 1 is already used by Brackets to "Collapse All") - so maybe a new combination?

edit: Wait... think I messed up!!!

@CardcaptorStacey

This comment has been minimized.

Copy link
Author

CardcaptorStacey commented Oct 1, 2015

I'm a silly sausage. It does work great now, thank you! Is there 1-9 of bookmarks?

Still can't skip to bookmark 1 as it is already used. Can the jump combination we changed? CMD+SHIFT+ALT+#? CMD+SHIFT+1 is already used by brackets

@robcaa

This comment has been minimized.

Copy link
Owner

robcaa commented Oct 19, 2015

Sorry for the late reply.
CMD+SHIFT+ALT+# is not too complicated?

If you really think that this is a good choice, I'm going to set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment