Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Marked DynamicModel as Abstract #24

Closed
wants to merge 1 commit into from

3 participants

Tom Doug Rohrer Brian Vallelunga
Tom

It seems to me that users of massive shouldn't ever create instances of DynamicModel, so I marked it as abstract.

Doug Rohrer

You can actually just create an instance of DynamicModel and pass it a few parameters to set the table, primary key, etc. I think it is a legitimate usage of DynamicModel - may not be appropriate to make DynamicModel abstract given this. See the README.markdown for an example of how to do this.

Tom

A good point. I somehow missed this fact when I was looking at the sample usage. Thanks, Jeet.

Brian Vallelunga

If this was rejected, why is DynamicModel now abstract again? Rob, did you make this change for a reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 22, 2011
  1. Tom
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Massive.cs
2  Massive.cs
View
@@ -87,7 +87,7 @@ public static class ObjectExtensions {
/// <summary>
/// A class that wraps your database table in Dynamic Funtime
/// </summary>
- public class DynamicModel {
+ public abstract class DynamicModel {
DbProviderFactory _factory;
string _connectionString;
Something went wrong with that request. Please try again.