Avoid a double-free in an error path.

Reported by Felix Groebert of the Google Security Team. ok beck@ miod@
robertbachmann · 62a110d447bb8c16a4c69629e28a42e8c39fd7e0 · jsing committed Nov 27, 2014 · Nov 27, 2014 · 62a110d
1 parent 3382f50
commit 62a110d447bb8c16a4c69629e28a42e8c39fd7e0
Unified Split

Showing with 1 addition and 2 deletions.

+1 −2 src/ssl/d1_srtp.c
diff --git a/src/ssl/d1_srtp.c b/src/ssl/d1_srtp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: d1_srtp.c,v 1.8 2014/07/14 08:21:47 miod Exp $ */
+/* $OpenBSD: d1_srtp.c,v 1.9 2014/11/16 14:12:47 jsing Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -355,7 +355,6 @@ ssl_parse_clienthello_use_srtp_ext(SSL *s, unsigned char *d, int len, int *al)
 		SSLerr(SSL_F_SSL_PARSE_CLIENTHELLO_USE_SRTP_EXT,
 		    SSL_R_BAD_SRTP_MKI_VALUE);
 		*al = SSL_AD_DECODE_ERROR;
-		sk_SRTP_PROTECTION_PROFILE_free(clnt);
 		goto done;
 	}