Skip to content

Commit

Permalink
refactored variable and method names
Browse files Browse the repository at this point in the history
  • Loading branch information
robertmarsal committed Oct 10, 2012
1 parent 1c909df commit 3d80da0
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
22 changes: 11 additions & 11 deletions library/Zend/Code/Generator/ClassGenerator.php
Expand Up @@ -70,7 +70,7 @@ class ClassGenerator extends AbstractGenerator
/**
* @var array Array of string names
*/
protected $useClasses = array();
protected $uses = array();

/**
* fromReflection() - build a Code Generation Php Object from a Class Reflection
Expand Down Expand Up @@ -489,12 +489,12 @@ public function addPropertyFromGenerator(PropertyGenerator $property)
*
* @param string $useClass
*/
public function addUseClass($useClass, $useClassAlias = null)
public function addUse($use, $useAlias = null)
{
if (!empty($useClassAlias)) {
$useClass .= ' as ' . $useClassAlias;
if (!empty($useAlias)) {
$use .= ' as ' . $useAlias;
}
$this->useClasses[] = $useClass;
$this->uses[] = $use;
}

/**
Expand Down Expand Up @@ -528,9 +528,9 @@ public function getProperty($propertyName)
*
* @return array
*/
public function getUseClasses()
public function getUses()
{
return $this->useClasses;
return $this->uses;
}

/**
Expand Down Expand Up @@ -692,10 +692,10 @@ public function generate()
$output .= 'namespace ' . $namespace . ';' . self::LINE_FEED . self::LINE_FEED;
}

$useClasses = $this->getUseClasses();
if (!empty($useClasses)) {
foreach ($useClasses as $useClass) {
$output .= 'use ' . $useClass . ';' . self::LINE_FEED;
$uses = $this->getUses();
if (!empty($uses)) {
foreach ($uses as $use) {
$output .= 'use ' . $use . ';' . self::LINE_FEED;
}
$output .= self::LINE_FEED;
}
Expand Down
6 changes: 3 additions & 3 deletions tests/ZendTest/Code/Generator/ClassGeneratorTest.php
Expand Up @@ -366,12 +366,12 @@ public function testPassingANamespacedClassnameShouldGenerateAClassnameWithoutIt
/**
* @group ZF2-151
*/
public function testAddUseClass()
public function testAddUses()
{
$classGenerator = new ClassGenerator();
$classGenerator->setName('My\Class');
$classGenerator->addUseClass('My\First\Use\Class');
$classGenerator->addUseClass('My\Second\Use\Class', 'MyAlias');
$classGenerator->addUse('My\First\Use\Class');
$classGenerator->addUse('My\Second\Use\Class', 'MyAlias');
$generated = $classGenerator->generate();

$this->assertContains('use My\First\Use\Class;', $generated);
Expand Down

0 comments on commit 3d80da0

Please sign in to comment.