Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cargo.lock from gitignore #12

Closed
robertdfrench opened this issue Oct 10, 2021 · 0 comments
Closed

Remove Cargo.lock from gitignore #12

robertdfrench opened this issue Oct 10, 2021 · 0 comments
Assignees
@calebwherry
Labels
enhancement New feature or request
Milestone
Git PR v1.0.0

Comments

@robertdfrench
Copy link
Owner

The .gitignore generated by GitHub says:

Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

so we should do that.
@calebwherry calebwherry self-assigned this Oct 11, 2021
@calebwherry calebwherry added this to the Git PR v1.0.0 milestone Oct 11, 2021
@calebwherry calebwherry added the enhancement New feature or request label Oct 11, 2021
calebwherry pushed a commit that referenced this issue Oct 17, 2021
Comment out Cargo.lock in gitignore. Fixes #12.
cb1ef93 
Commented Cargo.lock from gitignore so that we have a record
of why we did it. I think something like this is easy to forget
so leaving it along with the original comment makes sense.

Adding the version of Cargo.lock I get running on MacOs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebwherry calebwherry

Labels
enhancement New feature or request
Projects
None yet
Milestone
Git PR v1.0.0
Development

No branches or pull requests
2 participants
@robertdfrench @calebwherry