Robert Jones robertjustjones

Organizations

@opdots
robertjustjones deleted branch release-1.3.0 at robertjustjones/jsforce
robertjustjones deleted branch support-bulk-query at robertjustjones/jsforce
robertjustjones deleted branch update-package-version at robertjustjones/jsforce
robertjustjones deleted branch support-quickaction at robertjustjones/jsforce
robertjustjones deleted branch use-webdriver at robertjustjones/jsforce
robertjustjones deleted branch support-approval-layouts at robertjustjones/jsforce
robertjustjones deleted branch support-named-layout at robertjustjones/jsforce
robertjustjones deleted branch support-layout at robertjustjones/jsforce
robertjustjones deleted branch support-compact-layout at robertjustjones/jsforce
robertjustjones deleted branch support-process at robertjustjones/jsforce
robertjustjones deleted branch support-explain-query-plan at robertjustjones/jsforce
robertjustjones deleted branch support-open-in-reql at robertjustjones/jsforce
robertjustjones deleted branch test-runner-enhancement at robertjustjones/jsforce
robertjustjones deleted branch theme-rest-api at robertjustjones/jsforce
@robertjustjones
robertjustjones commented on pull request tmpvar/jsdom#1025
@robertjustjones

Hmm, ok, but it works now in node.js with your 3.1.x using node-canvas 1.2.1. Having two nodes is really going to suck.

robertjustjones commented on pull request tmpvar/jsdom#1025
@robertjustjones

Hey @domenic do you need me to take this further here for now? The fix could/should go into 3.x and 4.x, but Travis isn't passing because it's not …

robertjustjones commented on pull request tmpvar/jsdom#1025
@robertjustjones

To run the tests using io.js requires a recent fix to node-canvas: npm install git+https://github.com/Automattic/node-canvas.git

@robertjustjones
  • @robertjustjones e13b13e
    Update node-canvas to repo master to io.js fix.
robertjustjones commented on pull request tmpvar/jsdom#1025
@robertjustjones

@domenic I've added two tests that fail as follows without the fix. Let me know if there's a better location for these. AssertionError: A.width Ass…

@robertjustjones
  • @robertjustjones 8f8f7a9
    Include missing test file.
@robertjustjones
  • @robertjustjones e6aef1f
    Add node-canvas and canvas tests.
robertjustjones commented on pull request tmpvar/jsdom#1025
@robertjustjones

Thanks @domenic. I considered trying to add one but since the test requires that node-canvas be installed, I wasn't sure how you would want to stru…

robertjustjones commented on pull request Automattic/node-canvas#515
@robertjustjones

This PR goes along with the PR tmpvar/jsdom#1025 that fixes the jsdom integration of node-canvas.

robertjustjones commented on pull request Automattic/node-canvas#517
@robertjustjones

I've submitted a PR tmpvar/jsdom#1025 to address the error above, but I'm still curious whether the failed test in the PR is "intended behavior".