Keep the dashed line next to annotation actions for the time being
Pending a discussion about the design with our actual designer and a decision of what to display for annotations in various contexts (editing vs. not editing, replies vs. no replies) revert to the previous behavior of displaying a dashed line next to the annotation actions.

Pending a discussion about the design with our actual designer and a decision of what to display for annotations in various contexts (editing vs. not editing, replies vs. no replies) revert to the previous behavior of displaying a dashed line next to the annotation actions.
Add a minimum margin between the annotation heading and the editor
This fixes an issue where there was no gap between the heading and the top of the editor when creating a reply, which has no quotes.
robertknight
Unified Split

Showing with 2 additions and 15 deletions.

+1 −14 h/static/styles/annotations.scss

+1 −1 h/templates/client/annotation.html
diff --git a/h/static/styles/annotations.scss b/h/static/styles/annotations.scss
@@ -48,6 +48,7 @@ $annotation-card-left-padding: 10px;
  display: flex;
  flex-direction: row;
  align-items: flex-start;
+  margin-bottom: 5px;
 }

 .annotation-header__share-info {
@@ -70,20 +71,6 @@ $annotation-card-left-padding: 10px;
  margin-bottom: 0;
 }

-// for the last reply in an annotation thread,
-// add a border to the left of the footer which covers
-// the dotted line at the left edge of the annotation card
-//
-// See discussion in GH #2679
-.annotation-footer--last-reply {
-  $footer-border-width: $annotation-card-left-padding + 1px;
-
-  position: relative;
-  left: -$footer-border-width;
-  border-left: $footer-border-width solid white;
-  width: calc(100% + #{$footer-border-width});
-}
-
 .u-flex-spacer {
  flex-grow: 1;
 }
diff --git a/h/templates/client/annotation.html b/h/templates/client/annotation.html
@@ -105,7 +105,7 @@
  </div>
  <!-- / Tags -->

-  <footer class="annotation-footer" ng-class="{'annotation-footer--last-reply' : isLastReply}">
+  <footer class="annotation-footer">
    <div class="annotation-form-actions" ng-if="vm.editing" ng-switch="vm.action">
      <button ng-switch-when="delete"
              ng-click="vm.save()"