Skip to content

Robert Knight
robertknight

Jun 25, 2016
robertknight opened pull request hypothesis/h#3546
@robertknight
Prevent long URLs in quotes and bodies causing overflow
1 commit with 9 additions and 0 deletions
Jun 25, 2016
Jun 25, 2016
@robertknight
Share link for web-hosted PDFs now presents urn:x-pdf instead
Jun 25, 2016
robertknight commented on issue hypothesis/h#3491
@robertknight

Fixed in Hypothesis v0.30

robertknight deleted branch 3167-do-not-show-you-do-not-have-permission-card-while-waiting-for-document-to-load at hypothesis/h
Jun 24, 2016
Jun 24, 2016
@robertknight
Jun 24, 2016
robertknight merged pull request hypothesis/h#3529
@robertknight
Don't show permissions error before annotation
1 commit with 34 additions and 1 deletion
Jun 24, 2016
@robertknight
"You do not have permission to see this annotation" shown briefly before annotation appears
Jun 24, 2016
robertknight commented on pull request hypothesis/h#3529
@robertknight

LGTM

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3529
@robertknight

Small nit. The convention is to format this in a more compact way as: fakeCrossFrame.frames = [{ uri: '...', searchUris: [], }];

Jun 24, 2016
robertknight opened pull request hypothesis/h#3543
@robertknight
Fix #2965 (3/N) - Match annotations by ID or tag in drafts service and when removing annotations
2 commits with 46 additions and 13 deletions
Jun 24, 2016
@robertknight
Jun 24, 2016
Jun 24, 2016
@robertknight

Thanks @bfred-it , I had not seen that 👍

Jun 24, 2016
robertknight opened pull request hypothesis/h#3542
@robertknight
Remove unused alternative delete button from <annotation> component
1 commit with 2 additions and 6 deletions
Jun 24, 2016
Jun 24, 2016
robertknight opened pull request hypothesis/h#3541
@robertknight
Fix redundant calls to onEditText() in markdown editor component
1 commit with 2 additions and 4 deletions
Jun 24, 2016
Jun 24, 2016
robertknight closed pull request hypothesis/h#3535
@robertknight
Remove duplicated state in `<annotation>` component
Jun 24, 2016
robertknight commented on pull request hypothesis/h#3535
@robertknight

Discussed the high-level picture of the changes with @seanh yesterday. I'm now going to close this and pull out the individual commits into smaller…

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

As noted above, I think we should remove tabAnnotations and tabNotes here and just put the constants in a file that can be imported directly from the

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

Ah, I wondered where tabAnnotations was coming from. IMO it would be better to put these constants in a place that they can just be directly import…

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

I'm trying to follow a convention in new code that either: 1) All paths through the code return no value, in which case it always uses just return;

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

It confused me what tabSelection was when looking through the code above. I would suggest naming it selectedTab for consistency.

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

Imports should be sorted by require path where possible.

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

The name of this test differs from what the test actually checks. Here this test generates a filter function which only matches (not filters out) a…

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

fakeBuildThread is a fake for the buildThread() function. What you are trying to test here is just that the thread filter function passed to fakeBu…

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

Rather than re-defining these constants in each test, just import them once when setting up fakeAnnotationUI

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

Rather than redefining the constant here I'd suggest importing the actual value. What we should do in future is get ourselves to a state where we c…

Jun 24, 2016
robertknight commented on pull request hypothesis/h#3504
@robertknight

From the point of view of buildThread(), the threadFilterFn is generic - so actually here you only need a single test which checks that only annota…

Something went wrong with that request. Please try again.