support the non-standard Error.stack property #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deoxxa
force-pushed
the
error-stack-property
branch
from
cf57740
to
8739d2a
Compare
Popular runtimes (V8[1], SpiderMonkey[2], IE[3]) support a `stack` property on Error objects to get the error's stack as a string. This change adds support to otto for this same feature. It's implemented in a similar way to V8, using a getter function. This avoids generating the stack trace (which is done in a loop with string manipulation etc) unless the user requests it. There's no standard, or even trend, for the actual _content_ of `stack`, so we basically just copy what V8's traces look like. [1]: https://github.com/v8/v8/wiki/Stack%20Trace%20API [2]: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Error/stack [3]: http://msdn.microsoft.com/en-us/library/windows/apps/hh699850.aspx
deoxxa
force-pushed
the
error-stack-property
branch
from
8739d2a
to
c03dfd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popular runtimes (V8 1, SpiderMonkey 2, IE 3) support a
stackproperty on Error objects to get the error's stack as a string.
This change adds support to otto for this same feature. It's implemented
in a similar way to V8, using a getter function. This avoids generating
the stack trace (which is done in a loop with string manipulation etc)
unless the user requests it. There's no standard, or even trend, for the
actual content of
stack, so we basically just copy what V8's traceslook like.